Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reader does not get proper styling #138

Closed
foss- opened this issue Aug 20, 2023 · 7 comments
Closed

[BUG] Reader does not get proper styling #138

foss- opened this issue Aug 20, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@foss-
Copy link

foss- commented Aug 20, 2023

Thanks so much for this early alpha of Night for Zotero 7 - Zotero just isn't complete without this add-on!

Is your feature request related to a problem? Please describe.
In a brief test, PDF files are not shown in dark mode, which was possible in previous versions for Zotero 6. Maybe a known limitation of this early alpha?

Describe the solution you'd like
Add option to also show PDF files in dark mode (think colors were inverted?).

Additional context
macOS 13.5.1
Zotero 7.0.0b36
Night for Zotero 7 a0.1.0-0

@foss- foss- added the enhancement New feature or request label Aug 20, 2023
@tefkah tefkah added bug Something isn't working and removed enhancement New feature or request labels Aug 20, 2023
@tefkah
Copy link
Owner

tefkah commented Aug 20, 2023

did you press/can you see this button?
image

@tefkah tefkah changed the title [FEAT] PDF files not shown in dark mode [BUG] PDF files not shown in dark mode Aug 20, 2023
@tefkah
Copy link
Owner

tefkah commented Aug 20, 2023

Also, when you say "PDF Files not shown in dark mode", you mean that the theme of the files is not dark right? not that you cannot see the files at all

@tefkah
Copy link
Owner

tefkah commented Aug 20, 2023

oh no i see now, it's not working properly. I was using a very old beta, will fix

@tefkah tefkah changed the title [BUG] PDF files not shown in dark mode [BUG] Reader does not get proper styling Aug 20, 2023
@foss-
Copy link
Author

foss- commented Aug 20, 2023

This is what I am seeing. Seems dark mode is not applied to displayed PDF files. Sorry, should have been more specific and provided a screenshot. The surrounding UI is using dark mode as expected.
a

@tefkah
Copy link
Owner

tefkah commented Aug 20, 2023

Yes I'm seeing the same thing.

Reason is in between the version of the beta I was using to test and the latest version Zotero redid the PDF reader a bit, hence why my method no longer worked. I've got it running again, expect a fix later today

@tefkah
Copy link
Owner

tefkah commented Aug 20, 2023

@foss-
Copy link
Author

foss- commented Aug 20, 2023

Fix verified ❤️

macOS 13.5.1
Zotero 7.0.0b36
Night for Zotero 7 a0.1.0-1

@foss- foss- closed this as completed Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants