Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible enum type with base class #479

Closed
tefra opened this issue May 4, 2021 · 3 comments
Closed

Incompatible enum type with base class #479

tefra opened this issue May 4, 2021 · 3 comments

Comments

@tefra
Copy link
Owner

tefra commented May 4, 2021

(expression has type "Optional[IanaCountryTldEnumeration]", base class "EntityStructure" defined the type as "Optional[str]")

Generate base type for enums

tefra added a commit that referenced this issue May 4, 2021
tefra added a commit that referenced this issue May 4, 2021
@tefra
Copy link
Owner Author

tefra commented May 4, 2021

This will be tricky to implement 😞

@tefra
Copy link
Owner Author

tefra commented Jun 5, 2021

It's way to tricky to handle these cases, the enum converter will need a lot of hacking and we will have a tone of issues with mixed type enumerations. I am thinking that for these cases we should ignore the subclass override type annotation.

@tefra
Copy link
Owner Author

tefra commented Jun 5, 2021

closed in #516

@tefra tefra closed this as completed Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant