Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonParser: handle class and primitive unions #370

Merged
merged 1 commit into from
Jan 1, 2021
Merged

JsonParser: handle class and primitive unions #370

merged 1 commit into from
Jan 1, 2021

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jan 1, 2021

Closes #369

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #370 (5faee9a) into master (c31e7c4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #370   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           70        70           
  Lines         5671      5680    +9     
  Branches       997      1000    +3     
=========================================
+ Hits          5671      5680    +9     
Impacted Files Coverage Δ
xsdata/formats/dataclass/parsers/json.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31e7c4...5faee9a. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tefra tefra merged commit dcca4a7 into master Jan 1, 2021
@tefra tefra deleted the issue-369 branch January 1, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonParser failes on union fields with dataclasses and primitive types
1 participant