Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement iterwalk for xml.etree.ElementTree #546

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

tefra
Copy link
Owner

@tefra tefra commented Jun 28, 2021

Bring up to speed native xml event handler

  • parse from element or tree
  • xinclude for XmlEventHandler
  • py36-py38 xinclude has no base_url

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #546 (508a93a) into master (a3ccfbf) will decrease coverage by 0.20%.
The diff coverage is 69.23%.

❗ Current head 508a93a differs from pull request most recent head 4c2bf8c. Consider uploading reports for the commit 4c2bf8c to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            master     #546      +/-   ##
===========================================
- Coverage   100.00%   99.79%   -0.21%     
===========================================
  Files           93       93              
  Lines         7767     7794      +27     
  Branches      1337     1343       +6     
===========================================
+ Hits          7767     7778      +11     
- Misses           0       15      +15     
- Partials         0        1       +1     
Impacted Files Coverage Δ
...sdata/formats/dataclass/parsers/handlers/native.py 82.60% <57.89%> (-17.40%) ⬇️
xsdata/codegen/container.py 100.00% <100.00%> (ø)
xsdata/codegen/handlers/class_name_conflict.py 100.00% <100.00%> (ø)
xsdata/codegen/mappers/definitions.py 100.00% <100.00%> (ø)
xsdata/formats/dataclass/serializers/xml.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ccfbf...4c2bf8c. Read the comment docs.

@tefra tefra force-pushed the native-xinculde-parse-from-element branch 10 times, most recently from 508a93a to adb7b38 Compare June 29, 2021 19:47
@tefra tefra force-pushed the native-xinculde-parse-from-element branch from adb7b38 to 4c2bf8c Compare June 29, 2021 20:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tefra tefra merged commit d5a0d03 into master Jun 29, 2021
@tefra tefra deleted the native-xinculde-parse-from-element branch June 29, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant