Remove the internal prefix for value fields #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: In the past enumeration classes were allowed to be inner|nested. To resolve that issues I had used the prefix @ for value fields in order to quickly identify these cases. I know it was an ugly hack but worked well till now that someone noticed the conflict with the originalCase name convention. Since that part of the code was hackish and not really used anymore we can get rid for the code and the silly prefix.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 94 94
Lines 8214 8212 -2
Branches 1584 1583 -1
=========================================
- Hits 8214 8212 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
The originalCase convention performs no string transformations when used for field/classes/... names.
The generator is also using the field name
@valuefor all infered text nodes.These two don't work very well together.
Resolves #646
🔗 What I've Done
In the past enumeration classes were allowed to be inner|nested. To resolve that issue I used the prefix @ for value fields in order to quickly identify these cases when the generator had to copy inner classes from one class to another.
It's being a while now that all enumeration classes are promoted to root classes, so that hack to identify these cases is no longer necessary so it's safe to remove that part of the code and also remove the @ prefix that is causing the issue #646
💬 Comments
Hopefully most of these hacks from the early days are long gone.
🛫 Checklist