Prepare next release (0.4.7) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jquast
commented
Jun 10, 2023
•
jquast
commented
- add py3.5 to 3.11 targets to tox.ini
- fix really slow tests, make lrzsz package optional
- three small additional bugfixes about optional callback and CLI
- remove unused or unreachable code and tests
use them if you got 'em
bugfix: callback() now called for some kinds of errors bugfix: 'select' module not imported when using CLI bugfix: CLI 'python -m xmodem send', recv still not implemented! remove code and CLI options that aren't implemented, we should probably implement the 'xmodem send' sub-command soon .. change: remove unused runx() function change: remove the serial arguments and module import they were never implemented! change: set 'send error:' msg loglevel info -> error change: set 'error_count reached' msg loglevel info -> error change: set 'recv error: putc failed' msg loglevel debug -> warning change: remove unused 'char' variable
- make 'lrzsz' package optional, using pytest.mark.skipif() - add .editorconfig - add pytest.ini remove `test/functional/test.py`, somewhat useful ideas that have since been implemented in automatic pytests. This is out-of-date py2-only code, about bytes/ord/chr, StringIO(), and some unused ideas like simulating modem jitter. add a few specific tests, for more systemic coverage, it is a good idea to use these callbacks in automatic tests, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.