Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#44 - add Vtype-def-position feature #115

Merged
merged 2 commits into from
Oct 12, 2023
Merged

#44 - add Vtype-def-position feature #115

merged 2 commits into from
Oct 12, 2023

Conversation

tribbloid
Copy link
Collaborator

voila

@tribbloid tribbloid requested a review from tek October 6, 2023 17:40
@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Test Report (2.13.7)

99 tests  +2   99 ✔️ +2   16s ⏱️ +4s
16 suites +1     0 💤 ±0 
16 files   +1     0 ❌ ±0 

Results for commit 3706ef7. ± Comparison against base commit 140e6e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Test Report (2.13.8)

99 tests  +2   99 ✔️ +2   14s ⏱️ -2s
16 suites +1     0 💤 ±0 
16 files   +1     0 ❌ ±0 

Results for commit 3706ef7. ± Comparison against base commit 140e6e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Test Report (2.13.9)

99 tests  +2   99 ✔️ +2   18s ⏱️ +4s
16 suites +1     0 💤 ±0 
16 files   +1     0 ❌ ±0 

Results for commit 3706ef7. ± Comparison against base commit 140e6e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Test Report (2.13.10)

99 tests  +2   99 ✔️ +2   16s ⏱️ +3s
16 suites +1     0 💤 ±0 
16 files   +1     0 ❌ ±0 

Results for commit 3706ef7. ± Comparison against base commit 140e6e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Test Report (2.13.11)

99 tests  +2   99 ✔️ +2   13s ⏱️ ±0s
16 suites +1     0 💤 ±0 
16 files   +1     0 ❌ ±0 

Results for commit 3706ef7. ± Comparison against base commit 140e6e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Test Report (2.13.12)

99 tests  +2   99 ✔️ +2   14s ⏱️ ±0s
16 suites +1     0 💤 ±0 
16 files   +1     0 ❌ ±0 

Results for commit 3706ef7. ± Comparison against base commit 140e6e9.

♻️ This comment has been updated with latest results.

@tribbloid
Copy link
Collaborator Author

@tek do you have time to have a look? Only 2 test cases where introduced.

This should close #44

tek
tek approved these changes Oct 11, 2023
View reviewed changes
Copy link
Owner

@tek tek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tribbloid tribbloid mentioned this pull request Oct 12, 2023
Closed
@tribbloid tribbloid merged commit 7fe1ec1 into master Oct 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tek tek tek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tribbloid @tek