-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropped the extra thread hop when calling results #825
Conversation
required with Flutter 3.0.
Oops, i edited macos instead of iOS. I'll fix that. |
Done. |
Thanks again! |
Good and thanks!, I was not aware of that. I think I have a unit test (https://github.com/tekartik/sqflite/blob/master/sqflite/test/sqflite_macos_impl_test.dart) that ensure that iOS and MacOS implementation are the same (I also have a script https://github.com/tekartik/sqflite/blob/master/sqflite_support/tool/copy_ios_code_to_macos.dart that copy the code) which will likely fail (did you run flutter test?). Good if you could add a way to make it compatible for both? (likely using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks for handling this constraint (but hopefully it is easier to maintain for both)
v2.0.3-dev.2 has been published (and tagged and master is up to date). If everything works fine for you I'd like to publish it as stable soon (in the next 7 days). Thanks again for your support! |
It's no longer required with Flutter 3.0 for iOS and Android.