Implemented background platform channels #830
Conversation
thread to using the plugin thread pool to do so.
| @@ -60,6 +60,6 @@ dependencies { | |||
| androidTestImplementation 'androidx.test.ext:junit:1.1.2' | |||
| androidTestImplementation 'androidx.test:runner:1.3.0' | |||
| androidTestImplementation 'androidx.test:runner:1.3.0' | |||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.3.0' | |||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0' | |||
There was a problem hiding this comment.
I'm not sure if we want to check this in. I had to make this change locally to fix gradle dependency resolution.
There was a problem hiding this comment.
I try to use the latest version as much as possible too!
|
Thanks again for following flutter evolutions on this plugin. Indeed SQLite has some limitation on threads that might not match the flutter thread pool. For example, in a transaction, all commands must happen in the same thread so I think we still have to run in a dedicated thread on the native side (I might be wrong though, don't take anything for granted), at least on Android ((i.e. if a query happen in a different thread than the one that called |
|
I have published version 2.0.3-dev.4 with your changes. I have only tested on Android. |
|
It's my pleasure. Just to warn you, I'll be in the office one more day (6/28) than I'm out for vacation for a couple of weeks. So if you need something I can take a look tomorrow. |
fixes #719
This makes all the channel calls happen on thread pool instead of executing on the platform thread. It is still a bit inefficient since technically we could be executing the sqlite commands on the thread pool but I had some difficultly implementing it on Android. Sqlite would complain about getting a connection for all the threads in the thread pool.
This is still an improvement. With flutter's
customer moneywe are seeing sqlite requests happening at startup when the platform thread is very busy so the sqlite requests are being throttled by the platform thread when they have no need to execute on the platform thread. Especially on Android.Don't let the small change fool the reviewer. This is a large change in terms of functionality. I've looked through the code and ran the tests and I think the change is safe.