Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instrument sentry #57

Merged
merged 2 commits into from
Feb 17, 2024
Merged

feat: instrument sentry #57

merged 2 commits into from
Feb 17, 2024

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Feb 17, 2024

Closes #50

@aldy505 aldy505 requested a review from elianiva February 17, 2024 06:35
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 324 lines in your changes are missing coverage. Please review.

Comparison is base (f2b1795) 25.89% compared to head (6e360d9) 25.76%.

Files Patch % Lines
src/application/adapters/GithubAdapter.ts 0.00% 90 Missing ⚠️
src/utils/honoOtelTracer.ts 0.00% 52 Missing and 1 partial ⚠️
src/application/webhook/GithubWebhook.ts 0.00% 52 Missing ⚠️
src/tracing.ts 0.00% 48 Missing and 1 partial ⚠️
src/presentation/event-handlers/Deployment.ts 13.63% 19 Missing ⚠️
src/presentation/routes/GithubRoute.ts 0.00% 19 Missing ⚠️
src/application/App.ts 0.00% 14 Missing and 1 partial ⚠️
src/presentation/routes/GitlabRoute.ts 0.00% 13 Missing and 1 partial ⚠️
src/index.ts 0.00% 11 Missing ⚠️
src/presentation/TelegramPresenter.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   25.89%   25.76%   -0.14%     
==========================================
  Files          46       47       +1     
  Lines        2197     2278      +81     
  Branches       85       92       +7     
==========================================
+ Hits          569      587      +18     
- Misses       1597     1659      +62     
- Partials       31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@elianiva elianiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anjay, hono ga tuh

@elianiva
Copy link
Member

btw conflict, can't be bothered to fix

@aldy505
Copy link
Member Author

aldy505 commented Feb 17, 2024

btw conflict, can't be bothered to fix

@elianiva Done

@aldy505 aldy505 merged commit 70c2373 into master Feb 17, 2024
5 of 7 checks passed
@aldy505 aldy505 deleted the feat/instrument-sentry branch February 17, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instrument sentry
2 participants