Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clojure): add implode and explode #8

Merged
merged 6 commits into from
Mar 19, 2022
Merged

feat(clojure): add implode and explode #8

merged 6 commits into from
Mar 19, 2022

Conversation

elianiva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 19, 2022 •
edited
Loading

Codecov Report

Merging #8 (8bcb764) into master (1b6d576) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           17        33   +16     
=========================================
+ Hits            17        33   +16
Flag Coverage Δ
clojure 100.00% <100.00%> (?)
csharp 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clojure/src/pehape/string.clj 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6d576...8bcb764. Read the comment docs.

@elianiva
Copy link
Member Author

brb benerin CI

@elianiva elianiva force-pushed the clojure/explode-implode branch from fad26d8 to 7976ade Compare March 19, 2022 05:04
ronnygunawan
ronnygunawan requested changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@ronnygunawan ronnygunawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM

.github/workflows/pr_clojure.yml Outdated Show resolved Hide resolved
clojure/src/pehape/string.clj Outdated Show resolved Hide resolved
clojure/src/pehape/string.clj Outdated Show resolved Hide resolved
clojure/src/pehape/string.clj Outdated Show resolved Hide resolved
clojure/src/pehape/string.clj Outdated Show resolved Hide resolved
ronnygunawan
ronnygunawan requested changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@ronnygunawan ronnygunawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buat nambah coverage

clojure/test/pehape/string_test.clj Show resolved Hide resolved
@elianiva elianiva mentioned this pull request Mar 19, 2022
Open
60 tasks
ronnygunawan
ronnygunawan approved these changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@ronnygunawan ronnygunawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantap LGTM

@ronnygunawan ronnygunawan merged commit 66e141b into master Mar 19, 2022
@ronnygunawan ronnygunawan deleted the clojure/explode-implode branch March 19, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronnygunawan ronnygunawan ronnygunawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elianiva @ronnygunawan