Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rce): upgrade to node 20 #158

Merged
merged 5 commits into from
Mar 6, 2024
Merged

feat(rce): upgrade to node 20 #158

merged 5 commits into from
Mar 6, 2024

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Jan 14, 2024

Closes #156

@aldy505 aldy505 added the dependencies Pull requests that update a dependency file label Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: Patch coverage is 3.24675% with 149 lines in your changes are missing coverage. Please review.

Project coverage is 60.40%. Comparing base (a19d1dd) to head (35691af).
Report is 2 commits behind head on master.

Files Patch % Lines
rce/src/RceService.ts 0.00% 98 Missing ⚠️
rce/src/runtime/acquire.ts 7.31% 38 Missing ⚠️
rce/src/index.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #158       +/-   ##
===========================================
- Coverage   81.17%   60.40%   -20.77%     
===========================================
  Files          34       39        +5     
  Lines        1535     2344      +809     
  Branches      140      173       +33     
===========================================
+ Hits         1246     1416      +170     
- Misses        223      883      +660     
+ Partials       66       45       -21     
Flag Coverage Δ
auth 41.31% <ø> (ø)
rce 44.46% <3.24%> (-46.00%) ⬇️
sdk-dotnet 89.21% <ø> (+1.47%) ⬆️
sdk-go 66.48% <ø> (ø)
sdk-javascript 88.69% <ø> (ø)
sdk-python 99.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elianiva
Copy link
Member

CI failing, something something mark @sentry/tracing as external

@aldy505
Copy link
Member Author

aldy505 commented Jan 17, 2024

I really wanted to migrate ava to vitest. Might do this by the end of the week.

@elianiva elianiva merged commit 20f3c61 into master Mar 6, 2024
26 of 28 checks passed
@elianiva elianiva deleted the feat/rce/upgrade-node-20 branch March 6, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump RCE to Node 20
2 participants