Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expense list page #10

Merged
merged 7 commits into from
May 24, 2024
Merged

feat: expense list page #10

merged 7 commits into from
May 24, 2024

Conversation

qepo17
Copy link
Collaborator

@qepo17 qepo17 commented May 23, 2024

image

@qepo17 qepo17 requested review from aldy505 and elianiva May 23, 2024 09:49
@qepo17 qepo17 self-assigned this May 23, 2024
@qepo17 qepo17 linked an issue May 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@YogiPristiawan YogiPristiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gokil

app/components/expense-filter.tsx Outdated Show resolved Hide resolved
@@ -6,6 +6,11 @@ import {
ScrollRestoration,
} from "@remix-run/react";

import type { LinksFunction } from "@remix-run/node";
import styles from "./tailwind.css?url";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ini memang ada ?url begitu kah pak?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldy505
Copy link
Member

aldy505 commented May 24, 2024

@qepo17 ada conflict

@qepo17 qepo17 force-pushed the feat/expense-list branch from 7eafe24 to ed415d9 Compare May 24, 2024 08:54
@qepo17 qepo17 requested review from a team as code owners May 24, 2024 08:54
@qepo17 qepo17 force-pushed the feat/expense-list branch from 792a770 to 5258fb4 Compare May 24, 2024 09:30
Copy link
Member

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of, should we do i18n with all these?

return (
<nav className="flex justify-between items-center py-4 px-4 bg-white shadow-md">
<div>
{/* <img src="/path/to/logo.png" alt="Logo" className="h-8" /> */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed rather than just commented out

{new Intl.NumberFormat("id-ID", {
style: "currency",
currency: "IDR",
}).format(10000)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a prop later on

<CardExpense
title="Recent Expenses"
description="Here are the recent expenses made by the collective."
expenses={expenses}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a props later on

@aldy505 aldy505 merged commit 6c61e9d into master May 24, 2024
2 checks passed
@aldy505 aldy505 deleted the feat/expense-list branch May 24, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: Expense list page
4 participants