-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expense list page #10
Conversation
qepo17
commented
May 23, 2024
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gokil
@@ -6,6 +6,11 @@ import { | |||
ScrollRestoration, | |||
} from "@remix-run/react"; | |||
|
|||
import type { LinksFunction } from "@remix-run/node"; | |||
import styles from "./tailwind.css?url"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ini memang ada ?url
begitu kah pak?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ridhof yap, di step 5 https://tailwindcss.com/docs/guides/remix
@qepo17 ada conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speaking of, should we do i18n with all these?
return ( | ||
<nav className="flex justify-between items-center py-4 px-4 bg-white shadow-md"> | ||
<div> | ||
{/* <img src="/path/to/logo.png" alt="Logo" className="h-8" /> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed rather than just commented out
{new Intl.NumberFormat("id-ID", { | ||
style: "currency", | ||
currency: "IDR", | ||
}).format(10000)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a prop later on
<CardExpense | ||
title="Recent Expenses" | ||
description="Here are the recent expenses made by the collective." | ||
expenses={expenses} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a props later on