feat(backend): submit incident #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is only for submitting incident right? |
|
yes |
|
looks good to me 👍🏼 |
aldy505
requested changes
May 27, 2024
backend/main.go
Outdated
| @@ -53,6 +53,11 @@ func main() { | |||
| port = "5000" | |||
| } | |||
|
|
|||
| apiKey, ok := os.LookupEnv("API_KEY") | |||
| if !ok { | |||
| log.Fatal().Msg("API_KEY is required") | |||
There was a problem hiding this comment.
Shouldn't be Fatal though. Should be a warning that the API_KEY is not set, therefore you can't make API calls to endpoints that requires an API key.
aldy505
approved these changes
May 27, 2024
Comment on lines
+27
to
+29
| if incident.Timestamp.After(time.Now()) { | ||
| incidentStatus = IncidentStatusScheduled | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #29
x-api-keyheader for security. Therefore, you must addAPI_KEYto the environment. Let me know, if you have a better solution.