Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reach progression alternative 2 (replaces fix reach progression alternative) #151

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Feb 7, 2024

Replaces #110

various fixes 03_tww_db_dss

  • add DEFERRABLE INITIALLY DEFERRED also to re_table tww_od.re_building_group_disposal
  • delete txt_symbol
  • delete txt_text
  • delete progression_alternative - replace by reach_progression_alternative
  • fk_operating_company DEFERRABLE
  • wx class shortcut adde for wastewater_structure_text
  • rx class shortcut adde for reach_text
  • cx class shortcut adde for catchment_area_text
  • bx class shortcut adde for wastewater_structure_symbol
  • reach_progression_alternative.fk_reach added

fixes 09_tww_dictionaries

  • not adddataowner and provider in dictionary table in _text - as not existing in datamodel
  • delete dataowner and provider in dictionary table in _text - as not existing in datamodel
  • rename tablename in dictionary field to re_* - else linking not working
  • check attributes geometry - see add test for tww_sys tables #119 (comment)
  • adding reach_progression_alternative to dictionary tables in tww_sys
  • adding wastwater_structure_text, reach_text, catchment_text to dictionary tables in tww_sys

check entries for extra_tables _* (currently _planning_zone and _aquifier) - see #119 (comment) - Moved to extra issue #134 and pull request (to be defined)

sjib and others added 5 commits February 7, 2024 20:49
[x]  add DEFERRABLE INITIALLY DEFERRED also to re_table tww_od.re_building_group_disposal
[x] delete txt_symbol
[x] delete txt_text
[x] delete progression_alternative - replace by reach_progression_alternative
[x] fk_operating_company DEFERRABLE
[x] wx class shortcut adde for wastewater_structure_text
[x] rx class shortcut adde for reach_text
[x] cx class shortcut adde for catchment_area_text
[x] bx class shortcut adde for wastewater_structure_symbol
[x] reach_progression_alternative.fk_reach added
- [x] not adddataowner and provider in dictionary table in _text - as not existing in datamodel
- [x] delete dataowner and provider in dictionary table in _text - as not existing in datamodel
- [x] rename tablename in dictionary field to re_* - else linking not working
- [x] check attributes geometry - see #119 (comment)
- [ ] check entries for extra_tables _* (currently _planning_zone and _aquifier) - see #119 (comment) - Moved to extra issue #134 and pull request (to be defined)
- [x] adding reach_progression_alternative to dictionary tables in tww_sys
- [x] adding wastwater_structure_text, reach_text, catchment_text to dictionary tables in tww_sys
@sjib sjib requested a review from 3nids February 7, 2024 20:16
@sjib sjib added the fix Fixing something not working label Feb 7, 2024
@sjib sjib changed the title [WIP] fix reach progression alternative 2 (replaces fix reach progression alternative) fix reach progression alternative 2 (replaces fix reach progression alternative) Feb 7, 2024
@sjib
Copy link
Contributor Author

sjib commented Feb 7, 2024

@3nids This pull request replaces #110 - but has the same content, but is based on the latest Main branch.

@3nids 3nids merged commit 4356286 into main Feb 7, 2024
6 checks passed
@3nids 3nids deleted the 2024-02-fix-progression_alternative-2 branch February 7, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing something not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants