Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dictionary sql for extra dss2020 extension classes and rename to dss15_* #156

Merged
merged 32 commits into from
Mar 4, 2024
Merged

add dictionary sql for extra dss2020 extension classes and rename to dss15_* #156

merged 32 commits into from
Mar 4, 2024

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Feb 9, 2024 •
edited
Loading

  • 51_aquifier_2015_dictionaries.sql
  • 52_planning_zone_2015_dictionaries.sql
  • adapt script setup.sh

@sjib
Copy link
Contributor Author

sjib commented Feb 9, 2024

@3nids As far as I see it should be ok now from the datamodel side. Else please let me know.

@sjib sjib requested a review from 3nids February 9, 2024 09:25
@sjib
Copy link
Contributor Author

sjib commented Feb 13, 2024

solves #134

@ponceta
Copy link
Member

ponceta commented Feb 13, 2024

@domi4484 @3nids we will need help from your side to fix the plugin / plugin test part.

@ponceta ponceta added datamodel Concerns the datamodel fix Fixing something not working labels Feb 13, 2024
@3nids 3nids closed this Feb 13, 2024
@3nids 3nids reopened this Feb 13, 2024
@ponceta ponceta self-requested a review February 20, 2024 06:24
@ponceta
Copy link
Member

ponceta commented Feb 20, 2024 •
edited
Loading

I'm not a huge fan of having _aquifer as a table name, if that's an extension we should have an abbreviation and these extensions should be clearly identified (this is already the case here but we would need an understandable prefix).

What about dss15_aquifer ? dss15_planningzone ?

ponceta
ponceta requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@ponceta ponceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback in the comments otherwise it looks good to me.

@sjib sjib changed the title add dictionary sql for extra dss2020 extension classes add dictionary sql for extra dss2020 extension classes and rename to dss15_* Feb 22, 2024
sjib
sjib commented Feb 22, 2024
View reviewed changes
datamodel/changelogs/0001/51_aquifier_2015.sql Outdated
FOR EACH ROW EXECUTE PROCEDURE
tww_sys.update_last_modified();

-------

/* ALTER TABLE tww_od.water_catchment ADD COLUMN fk_aquifier varchar (16);
ALTER TABLE tww_od.water_catchment ADD CONSTRAINT rel_water_catchment_aquifier FOREIGN KEY (fk_aquifier) REFERENCES tww_od._aquifier(obj_id) ON UPDATE CASCADE ON DELETE set null; */
/* ALTER TABLE tww_od.water_catchment ADD COLUMN fk_dss15_aquifer varchar (16);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rename from fk_aquifier to fk_dss15_aquifier or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this is commented?

@sjib

This comment was marked as resolved.

Sign in to view
sjib added 2 commits February 22, 2024 18:01
@sjib
comment adapted
a0c42a2
@sjib
Changed spelling mistake
07fbb5d 
dss15_aquifer instead of dss15_aquifier
@sjib

This comment was marked as resolved.

Sign in to view
@sjib sjib requested a review from ponceta February 22, 2024 20:59
@sjib
Copy link
Contributor Author

sjib commented Feb 26, 2024 •
edited by ponceta
Loading

What about dss15_aquifer ? dss15_planningzone ?

@ponceta Is now all adapted.

  • Can you check my open questions and then merge.
  • And take care of the qgs ?

@sjib sjib mentioned this pull request Feb 26, 2024
Merged
@ponceta ponceta merged commit 6ac6f7b into main Mar 4, 2024
9 checks passed
@ponceta ponceta deleted the dictionaries_dss2020_extension_tables branch March 4, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponceta ponceta ponceta approved these changes

@3nids 3nids Awaiting requested review from 3nids

Assignees

@sjib sjib

Labels
datamodel Concerns the datamodel fix Fixing something not working
Projects
None yet
Milestone
TEKSI Wastewater VSA DSS 2020 Part 1
Development

Successfully merging this pull request may close these issues.
3 participants
@sjib @ponceta @3nids