check validity of presets on startup #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cymed
changed the title
for more information, see https://pre-commit.ci
sjib
reviewed
Jul 10, 2024
|
@cymed Wow - nice new feature! |
cymed
changed the title
|
For me this looks good. May be the (TEKSI) service providers want to comment also. |
sjib
approved these changes
Jul 10, 2024
domi4484
reviewed
Jul 17, 2024
|
|
||
| pgservice = pg_layer.dataProvider().uri().service() | ||
| msgs = tww_check_oid_prefix(pgservice) | ||
| msgs.extend(tww_check_oid_prefix(pgservice)) |
There was a problem hiding this comment.
@cymed should that be msgs.extend(tww_check_fk_defaults(pgservice)?
EDIT: And in general tww_validity_check is never called. What is the idea behind? should we do those checks at plugin start / project opening?
cymed
added a commit
to cymed/TEKSI-wastewater
that referenced
this pull request
Jul 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup, we should check if the database is suitable for production