Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that triggers stay active in case of error #319

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Ensure that triggers stay active in case of error #319

merged 7 commits into from
Jul 18, 2024

Conversation

domi4484
Copy link
Contributor

@domi4484 domi4484 commented Jul 17, 2024 •
edited
Loading

  • Better error handling
  • Add menu items and functionalities for:
    • Update symbology
    • Validity check
    • Enable / Disable symbology triggers
  • Enable / Disable symbology menus are enabled only for admin users
  • Validity check also checks for enabled triggers
  • Group database using functions in new DatabaseUtils class
  • Show TWW logo in plugin menu
  • Execute validity check on project open
  • Move DB config out of Interlis config
  • Remove need to restart plugin when changing Admin mode

Fixes #289, #264

image

@domi4484
Ensure that triggers stay active in case of error
84755e4 
- Better error handling
- Add menu items and functionalities for:
  - Update symbology
  - Validity check
  - Enable / Disable symbology triggers
- Group database using functions in new DatabaseUtils class
- Show TWW logo in plugin menu
@domi4484 domi4484 mentioned this pull request Jul 17, 2024
Closed
@sjib sjib mentioned this pull request Jul 17, 2024
Merged
@domi4484 domi4484 requested a review from ponceta July 18, 2024 05:43
@ponceta
Copy link
Member

ponceta commented Jul 18, 2024

Thank you @domi4484 , this is really great work and great improvements to the usability :

Here are the error messages on validity check :

image

image

image

image

This works well!

My only remark :

  • Could you add a message that:

Symbology has been successfully updated
after symbology update?

@ponceta ponceta added datamodel Concerns the datamodel plugin Concerns the wastewater plugin fix Fixing something not working labels Jul 18, 2024
@ponceta ponceta mentioned this pull request Jul 18, 2024
Closed
@domi4484
Copy link
Contributor Author

@ponceta thanks for the feedback!

I have added the dialog as requested and some more in case of error/success for the other actions. Some examples:

image

image

@cymed
Copy link
Contributor

cymed commented Jul 18, 2024 •
edited
Loading

Great additions

It might be handy to to have a generic

DatabaseUtils.fetchone(query str)
DatabaseUtils.fetchall(query str) 
DatabaseUtils.execute(query str)

@domi4484
Copy link
Contributor Author

It might be handy to to have a generic

Done thanks

@ponceta ponceta merged commit 25054e6 into main Jul 18, 2024
8 checks passed
@ponceta ponceta deleted the ensureTriggerAlwaysEnabled branch July 18, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponceta ponceta ponceta approved these changes

Assignees

@domi4484 domi4484

Labels
datamodel Concerns the datamodel fix Fixing something not working plugin Concerns the wastewater plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INTERLIS importer can leave triggers disabled in case of error
3 participants
@domi4484 @ponceta @cymed