Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce serial pk on default values #342

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Jul 26, 2024

solves #341

@sjib
Copy link
Contributor

sjib commented Jul 26, 2024

20240726_form_default_values_corrected_table

Table now works with second and third value

@sjib
Copy link
Contributor

sjib commented Aug 2, 2024

@cymed With you're new patch applied I get now the following error: CRITICAL Error : Could not check database validity: name 'item' is not defined

20240801_validity_check_on_startup
20240801_validity_check_tww_od default_values
20240801_validity_check

I hope I did all well.

Maybe still something to adapt here?

@staticmethod
def get_validity_check_issues() -> List[str]:
    messages = []
    messages = DatabaseUtils.check_oid_prefix()
    messages.extend(DatabaseUtils.check_fk_defaults())

    if not DatabaseUtils.check_symbology_triggers_enabled():
        messages.append("Symbology triggers are disabled")

    return messages

Else I have to make another test on a new clean version.

@sjib sjib added the fix Fixing something not working label Aug 2, 2024
@cymed
Copy link
Contributor Author

cymed commented Aug 2, 2024

Should work after renaming the iterator

@cymed
Copy link
Contributor Author

cymed commented Aug 5, 2024

Run docker-compose run qgis /usr/src/plugin/.docker/run-docker-tests.sh
/home/runner/work/_temp/e770bf66-fe88-4e72-a8e0-20face7ed591.sh: line 1: docker-compose: command not found

seems like a docker issue

field does not exist in od
@sjib
Copy link
Contributor

sjib commented Aug 6, 2024

When applying the new datamodel/changelogs/0001/14_default_values.sql without fk_dataprovider it works for me.
thanks @cymed

@sjib sjib added this to the TEKSI Wastewater 2024.0 milestone Aug 6, 2024
@sjib sjib self-requested a review August 6, 2024 12:44
Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok from my side.

@cymed cymed closed this Aug 7, 2024
@cymed cymed reopened this Aug 7, 2024
@ponceta ponceta closed this Aug 7, 2024
@ponceta ponceta reopened this Aug 7, 2024
@ponceta ponceta merged commit d3c0aca into teksi:main Aug 8, 2024
20 of 22 checks passed
@cymed cymed deleted the alter-pkey-on-default-values branch August 8, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing something not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants