harmonize trigger enabling/disabling

[cymed]

General

• Fix a bug
• Add a feature
• Maintenance / sustainability
• Add Documentation

Describe your changes

We need a way to enable/disable last_modification triggers from the plugin, see #368.

This PR creates the corresponding DB functions and calls them before importing.

Also, it moves symbology trigger checks out of the app folder, as they are created in sys

Screenshots

Issue ticket number and link

Checklist before requesting a review

• I have performed a self-review of my code
• If it is a core feature, I have added thorough tests.
• CI Tests are green
• The documentation is up to date with the proposed change.
• My work is ready for review

Checklist before merge

• All required reviews have been performed
• Comments are resolved
• Documentation is ready

[ponceta]

This is really a great cleanup for the future, and this will clearly ease our maintenance efforts for the next years.

[ponceta]

I'll run some test and then we will be able to merge this! Thank you a lot!

[ponceta]

This is great and works fine! Thank you @cymed

[ponceta]

@sjib please have a look at this and tell us if you're OK, since we moved some of the working logic to the app schema, this could require some adaptation in your datamodel generation scripts.

[ponceta]

@ponceta when this is merged, replicate this logic to TDH for consistency.

[sjib]

I think I have to take out these lines in the datamodel sql scripts:

ALTER TABLE tww_od.organisation ALTER COLUMN obj_id SET DEFAULT tww_sys.generate_oid('tww_od','organisation');

and the trigger statements

---

CREATE TRIGGER
update_last_modified_sia405cc_cable_point
BEFORE UPDATE OR INSERT ON
 tww_od.sia405cc_cable_point
FOR EACH ROW EXECUTE PROCEDURE
 tww_sys.update_last_modified();

Anything else @ponceta @cymed ?

[cymed]

I think I have to take out these lines in the datamodel sql scripts:

ALTER TABLE tww_od.organisation ALTER COLUMN obj_id SET DEFAULT tww_sys.generate_oid('tww_od','organisation');

and the trigger statements

CREATE TRIGGER
update_last_modified_sia405cc_cable_point
BEFORE UPDATE OR INSERT ON
 tww_od.sia405cc_cable_point
FOR EACH ROW EXECUTE PROCEDURE
 tww_sys.update_last_modified();

Anything else @ponceta @cymed ?

This is all on your side

[cymed]

@ponceta good to merge?