Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QGIS project #67

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Update QGIS project #67

merged 3 commits into from
Jan 9, 2024

Conversation

3nids
Copy link
Contributor

@3nids 3nids commented Jan 9, 2024

This is the project file from this commit fdf205f in PR #24

I fixed the typo (wn_elevation_accuracy), is it expected that there were still some mentions about this despite being fixed in the datamodel? i.e. could it be that the project is not up to date with the last datamodel?

The project still contains some QGEP words in it, which is a banned keyword, this has to be fixed.

This PR supersedes #24.

@3nids 3nids mentioned this pull request Jan 9, 2024
@urskaufmann
Copy link
Contributor

elevation_accuracy: I did correct this with QGIS (not with a notepad) and I can find in QGIS no more "accuray". With notepad, there are still 17 accuray. Don't no what happens, if I change this with notepad.

Similar with qgep: there is still 24x qgep in a path to a dictionary on my server and twice is qgep a part of a filename (od_file20160921105557083_object_class_obj_id_vw_wastewater_node_qgep"). I can not handle this with QGIS...

project-files seems to have some legacy issues

@ponceta
Copy link
Member

ponceta commented Jan 9, 2024

2023-12-11
https://raw.githubusercontent.com/teksi/wastewater/d03568706aa27c656d48db1eb08bb26f23cf8244/project/teksi_wastewater.qgs

2024-01-07
https://raw.githubusercontent.com/teksi/wastewater/4733f655814d28566d427261afb96c173836918a/project/teksi_wastewater.qgs

QGEP is mentionned in both files :

            <editform tolerant="1">T:/12_GIS/01_QGIS/QGEP/qgep-test/tww_project_2020/forms/reach.ui</editform>
            <editforminit></editforminit>
            <editforminitcodesource>0</editforminitcodesource>
            <editforminitfilepath>T:/12_GIS/01_QGIS/QGEP/qgep-test/tww_project_2020</editforminitfilepath>
            <editforminitcode># -*- coding: utf-8 -*-

@3nids
Copy link
Contributor Author

3nids commented Jan 9, 2024

I guess these lines could easily be dropped

Fix QGEP mentions
@ponceta ponceta self-requested a review January 9, 2024 14:00
Copy link
Member

@ponceta ponceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great project enhancements by @urskaufmann ! Thank you a lot!

@ponceta ponceta assigned 3nids and unassigned ponceta Jan 9, 2024
@ponceta ponceta added the QGIS project Concern the .qgs QGIS project label Jan 9, 2024
@3nids 3nids merged commit 6d52e6b into main Jan 9, 2024
@3nids 3nids deleted the project-v2 branch January 9, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QGIS project Concern the .qgs QGIS project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants