Add is_primary bool to function hierarchic vl #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cymed
changed the title
cymed
changed the title
sjib
reviewed
Feb 9, 2024
| @@ -53,6 +53,17 @@ SET order_fct_hierarchic= | |||
| ] | |||
| ,code); | |||
|
|
|||
| -- this column is an extension to the VSA data model and facilitates filtering out primary features | |||
| ALTER TABLE tww_vl.channel_function_hierarchic ADD COLUMN is_primary bool; | |||
3nids
reviewed
Feb 13, 2024
|
@cymed Would also be good to add the DEFAULT FALSE in the adaptions you made to tww_od.organisation see https://github.com/teksi/wastewater/pull/150/files ALTER TABLE tww_od.organisation ADD COLUMN _active bool; |
|
Plugin test error https://github.com/teksi/wastewater/actions/runs/7898133040/job/21554937421?pr=70 |
|
Tagging @sjib for review |
sjib
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many functionalities such as SWMM or MIKE exports allow filtering elements of the primary wastewater network. Up to now, all those scripts hardcode a list of primary entries in tww_vl.channel_function_hierarchic, making it cumbersome for people that use vl extensions. To facilitate the exports (and make them quicker), I suggest adding a datamodel extensions in the vl table.