Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm Task #334

Merged
merged 5 commits into from
Jun 19, 2020
Merged

Add helm Task #334

merged 5 commits into from
Jun 19, 2020

Conversation

fhopfensperger
Copy link
Member

@fhopfensperger fhopfensperger commented May 26, 2020 •
edited
Loading

Changes

This Task can be used to install/upgrade a helm chart (located in a git repo) into a Kubernetes/OpenShift Cluster.

Signed-off-by: Florian Hopfensperger florian.hopfensperger@de.ibm.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@fhopfensperger
This Task can be used to install/upgrade a helm chart into a Kubern…
b4fc16b 
…etes/OpenShift Cluster.

Signed-off-by: Florian Hopfensperger <florian.hopfensperger@de.ibm.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 26, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

  • ✅ Florian Hopfensperger (b4fc16b)

@tekton-robot tekton-robot requested review from bobcatfish and a user May 26, 2020 13:47
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2020
@tekton-robot
Copy link

Hi @fhopfensperger. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 26, 2020
@fhopfensperger
Copy link
Member Author

@sbwsg Sorry, I'm not sure what the next steps are. This is my first PR for tekton.

@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2020
@vdemeester
Copy link
Member

@fhopfensperger the invalid-owners-file means you need to be part of the organization — you can create a PR on tektoncd/community to add yourself (see tektoncd/community#106 for inspiration, you can say you mean to own a task in the catalog 😉 )

/cc @eddycharly @chmouel

@tekton-robot
Copy link

The following users are mentioned in OWNERS file(s) but are not members of the tektoncd org.

  • fhopfensperger
    • helm/OWNERS
    • helm/OWNERS

fhopfensperger added a commit to fhopfensperger/community that referenced this pull request Jun 3, 2020
@fhopfensperger
Add Florian to the org.
064f610 
Florian would like to add a new `helm` task to the Tekton Catalog. He would like to maintain and own this task.
tektoncd/catalog#334

Florian works in his daily job as a solution architect for IBM Germany, where he likes to rely on open source technologies. If he finds a bug in one of his used software, he does not hesitate to fix it or add new features. He has already spoken with the `helm` maintainers and is looking for active support to maintain this new Tekton Task.

Florian is excited about the cool features around Tekton and is looking forward to using them more and more in customer projects.

Signed-off-by: Florian Hopfensperger <florian.hopfensperger@de.ibm.com>
@fhopfensperger fhopfensperger mentioned this pull request Jun 3, 2020
Merged
@fhopfensperger
Copy link
Member Author

@vdemeester Thank you for the information 🙏
I just opened a pull request tektoncd/community#116
Hopefully, I did everything right. 🙈

tekton-robot pushed a commit to tektoncd/community that referenced this pull request Jun 3, 2020
@fhopfensperger @tekton-robot
Add Florian to the org.
084a226 
Florian would like to add a new `helm` task to the Tekton Catalog. He would like to maintain and own this task.
tektoncd/catalog#334

Florian works in his daily job as a solution architect for IBM Germany, where he likes to rely on open source technologies. If he finds a bug in one of his used software, he does not hesitate to fix it or add new features. He has already spoken with the `helm` maintainers and is looking for active support to maintain this new Tekton Task.

Florian is excited about the cool features around Tekton and is looking forward to using them more and more in customer projects.

Signed-off-by: Florian Hopfensperger <florian.hopfensperger@de.ibm.com>
@fhopfensperger
Copy link
Member Author

/verify-owners

@fhopfensperger
Copy link
Member Author

@vdemeester Sorry, I'm not sure if /verify-owners is working properly or if I'm doing something wrong? Could you help me, please?

@fhopfensperger
Copy link
Member Author

/verify-owners

@vdemeester vdemeester removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 19, 2020
vdemeester
vdemeester approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@vdemeester
Copy link
Member

/test pull-tekton-catalog-integration-tests

@tekton-robot tekton-robot merged commit 2fa2e40 into tektoncd:v1beta1 Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@chmouel chmouel Awaiting requested review from chmouel

@eddycharly eddycharly Awaiting requested review from eddycharly

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhopfensperger @tekton-robot @vdemeester