-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github-add-comment version 0.3 #664
Add github-add-comment version 0.3 #664
Conversation
/cc @chmouel |
Don't we want optional workspace instead of optional params? |
I am very bad at python 😞 so don't know how to check whether workspace is bound or not 😅. So I did a workaround by adding one more step that will check whether file is passed or it's a comment. In any of the case it will be moved to a file |
In your script I think it would look like: if "$(workspaces.foo.bound)" == "true": |
ohh... I thought it would be handled other way. Thanks @sbwsg 👍 |
1b7b308
to
968ff26
Compare
As of now github-add-comment task supports input of comments only via params. This PR adds support of workspaces if in case somebody wants to provide the comments via some file. One such use case can be:- In Catlin CI, logs are produced after executing catlin command on changed files which can contain multiple warnings and these warnings can be ingored by the user if not posted on the github PR as the CI is green. So all the logs would be stored in a file with proper formatting and then the shared workspace can be passed to the github-add-comment task along with the filename containing the formatted logs. Signed-off-by: vinamra28 <vinjain@redhat.com>
968ff26
to
ae0f0ec
Compare
/lgtm thanks |
/lgtm |
/lgtm 🥳 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
As of now github-add-comment task supports input of comments only via
params.
This PR adds support of workspaces if in case somebody wants to provide
the comments via some file. One such use case can be:-
In Catlin CI, logs are produced after executing catlin command on
changed files which can contain multiple warnings and these warnings can
be ingored by the user if not posted on the github PR as the CI is
green. So all the logs would be stored in a file with proper formatting
and then the shared workspace can be passed to the github-add-comment
task along with the filename containing the formatted logs.
Signed-off-by: vinamra28 vinjain@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide
for more details.