Add platforms annotation to kaniko task

[barthy1]

Changes

Annotation about linux/amd64,linux/s390x, and linux/ppc64le platforms was added to the latest versions of the kaniko task, as well as information which custom images to use for linux/s390x and linux/ppc64le platforms.
JQ_IMAGE parameter is introduced with default value from the existing task to be able to use custom image for non-Intel architecture.

The changes were tested for linux/amd64,linux/s390x, and linux/ppc64le platforms.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Follows the authoring recommendations
• Includes docs (if user facing)
• Includes tests (if functionality of task changed or new task added)
• Commit messages follow commit message best practices
• Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation

  • File path follows <kind>/<name>/<version>/name.yaml

  • Has README.md at <kind>/<name>/<version>/README.md

  • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

  • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

  • mandatory spec.description follows the convention

      ```
    
      spec:
        description: >-
          one line summary of the resource
    
          Paragraph(s) to describe the resource.
      ```
    

See the contribution guide
for more details.

---

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vinamra28]

@barthy1 this information would not be available to user who would be installing the task via tkn hub cli. Is there a way we can get an image which is a multi-arch build?

[barthy1]

For kaniko image - at this moment there is no multi-arch image for all 3 platforms. I am working on it, but the problem is complex and will take some time to resolve.
For jq image we can use multi-arch one - apteno/alpine-jq, the default stedolan/jq has only linux/amd64 support and community is not interested to build multi-arch version.

In general I agree that search via tkn hub won't show platform specific information, however at least user can find it at hub UI, tkn hub task details and catalog task description. At this moment I don't see any way to show something like that in standard cli search, except probably adding * after platforms specification and suggesting check the task documentation before usage :(
Do you have any ideas?

[barthy1]

Thinking about it more, also remembered some ideas suggested in this area:

• Multi architecture support for catalog resources #661 (comment) to have separate tasks for separate operating systems (same probably can be implemented for different archs)
• tool to combine all necessary images for different platforms into one manifests, something like https://github.com/imjasonh/combine

[barthy1]

@vinamra28 would it be ok for you to resolve this issue step be step?
I mean first step would be just document the differences between platforms in documentation, next step to either somehow generate multi-arch image or define task differently.

[vinamra28]

yeah will be good for first iteration 👍

[chmouel]

/lgtm

[vinamra28]

/test .*

[vdemeester]

/test pull-catalog-catlin-lint

[vdemeester]

/test pull-catalog-catlin-lint

[vdemeester]

task check-name-match has failed: "step-check-name" exited with code 2 (image: "docker-pullable://alpine@sha256:e1c082e3d3c45cccac829840a25941e679c25d438cc8412c2fa221cf1a824e6a"); for logs run: kubectl -n tekton-ci logs pull-catalog-catlin-run-ssmzq-check-name-match-f85nx-pod-8nl2t -c step-check-name

[check-name] + set -o pipefail
[check-name] + printf passed
[check-name] + '[[' '/test pull-catalog-catlin-lint
[check-name]
[check-name] ' '=='  ]]
[check-name] /tekton/scripts/script-0-8rgz4: line 19: syntax error: unexpected "|"

🤔

[vinamra28]

/test .*

[tekton-robot]

Catlin Output

FILE: task/kaniko/0.4/kaniko.yaml
WARN : Step "build-and-push" uses image "$(params.BUILDER_IMAGE)" that contains variables; skipping validation
WARN : Step "digest-to-results" uses image "$(params.JQ_IMAGE)" that contains variables; skipping validation

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In kaniko-digest-to-results line 2:
cat $(params.CONTEXT)/image-digested | jq '.[0].value' -rj | tee /tekton/results/IMAGE-DIGEST
    ^---------------^ SC2046: Quote this to prevent word splitting.
    ^-- SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...

[PuneetPunamiya]

/lgtm