-
Notifications
You must be signed in to change notification settings - Fork 249
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We don't currently have a VERSION in the release tarball. Which breaks `tkn version` when building from sources or with package managers (i.e: brew, deb, rpm etc.. ) On gorelease we grab the curren tag from git which should be defined in the git pipelineresource and output it to the VERSION file. Make would then see this file and add the proper flags if he sees it. (the LDFLAGS can be overrided if needed). Closes #231 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
- Loading branch information
1 parent
2ee8747
commit 93726c1
Showing
3 changed files
with
18 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,3 +42,6 @@ tags | |
|
||
#Mac | ||
.DS_Store | ||
|
||
# Generated from gorelease | ||
VERSION |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters