Skip to content

Commit

Permalink
add warning message for tkn task start --timeout
Browse files Browse the repository at this point in the history
  • Loading branch information
danielhelfand authored and tekton-robot committed Feb 26, 2020
1 parent e45c2ad commit a55040f
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/cmd/task/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"encoding/json"
"errors"
"fmt"
"log"
"strings"
"time"

Expand Down Expand Up @@ -112,6 +113,10 @@ like cat,foo,bar
`,
SilenceUsage: true,
Args: func(cmd *cobra.Command, args []string) error {
if opt.TimeOut != 3600 {
log.Println("WARNING: The --timeout flag will no longer be specified in seconds in v0.9.0. Learn more here: https://github.com/tektoncd/cli/issues/730")
log.Println("WARNING: The -t shortand for --timeout will no longer be available in v0.9.0.")
}
if err := flags.InitParams(p, cmd); err != nil {
return err
}
Expand Down Expand Up @@ -148,7 +153,6 @@ like cat,foo,bar
c.Flags().BoolVarP(&opt.Last, "last", "L", false, "re-run the task using last taskrun values")
c.Flags().StringVarP(&opt.UseTaskRun, "use-taskrun", "", "", "specify a taskrun name to use its values to re-run the taskrun")
flags.AddShellCompletion(c.Flags().Lookup("use-taskrun"), "__tkn_get_taskrun")

c.Flags().StringSliceVarP(&opt.Labels, "labels", "l", []string{}, "pass labels as label=value.")
c.Flags().BoolVarP(&opt.ShowLog, "showlog", "", false, "show logs right after starting the task")
c.Flags().StringVarP(&opt.Filename, "filename", "f", "", "local or remote file name containing a task definition")
Expand Down

0 comments on commit a55040f

Please sign in to comment.