Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline start creates only one resource #456

Closed
siamaksade opened this issue Nov 12, 2019 · 3 comments · Fixed by #457
Closed

Pipeline start creates only one resource #456

siamaksade opened this issue Nov 12, 2019 · 3 comments · Fixed by #457
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@siamaksade
Copy link

The following pipeline has 2 resources one of type git and another image but the start flow skips the image resource and starts the pipeline immediately after creating the git resource, which causes the pipelinerun to fail with missing resources:

$ tkn pipeline start petclinic-s2i-pipeline
no pipeline resource of type "git" found in namespace: pipelines-demo
please create new "git" resource
? Enter a name for a pipeline resource : petclinic-git
? Enter a value for url :  https://github.com/spring-projects/spring-petclinic
? Enter a value for revision :
New git resource "petclinic-git" has been created
resource status {}

Pipelinerun started: petclinic-s2i-pipeline-run-5bkp4
Showing logs...
PipelineRun pipelines-demo/petclinic-s2i-pipeline-run-5bkp4 doesn't bind Pipeline pipelines-demo/petclinic-s2i-pipeline's PipelineResources correctly: PipelineRun bound resources didn't match Pipeline: Didn't provide required values: [app-image]
@piyush-garg
Copy link
Contributor

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 12, 2019
@piyush-garg
Copy link
Contributor

piyush-garg commented Nov 12, 2019

we need to remove this https://github.com/tektoncd/cli/blob/master/pkg/cmd/pipeline/start.go#L213 and use continue

And for sure, add tests

piyush-garg added a commit to piyush-garg/cli that referenced this issue Nov 12, 2019
This will fix the issue of resource creation
failure in case of creating multiple
resources on fly while executing
tkn pipeline start command

Add tests

fix tektoncd#456
@piyush-garg
Copy link
Contributor

/assign

tekton-robot pushed a commit that referenced this issue Nov 13, 2019
This will fix the issue of resource creation
failure in case of creating multiple
resources on fly while executing
tkn pipeline start command

Add tests

fix #456
chmouel pushed a commit that referenced this issue Nov 22, 2019
This will fix the issue of resource creation
failure in case of creating multiple
resources on fly while executing
tkn pipeline start command

Add tests

fix #456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants