Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to existing --all subcommand for tasks and pipelines #702

Closed
ghost opened this issue Feb 11, 2020 · 1 comment · Fixed by #729
Closed

Add warning to existing --all subcommand for tasks and pipelines #702

ghost opened this issue Feb 11, 2020 · 1 comment · Fixed by #729
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Milestone
0.8.0 🐯

Comments

@ghost
Copy link

ghost commented Feb 11, 2020

Version and Operating System

0.7.x

The existing --all flag for task and pipeline delete will also delete the taskruns and pipelineruns related to those resources.

In 0.8 we're planning to use --all to delete every instance of a given resource kind. This is a change in the meaning of the --all flag for task and pipelines.

So, we should add a warning to the --all flag for task and pipelines that the meaning will be changing in an upcoming release as a way to warn users.

Related Issues

Add --all to the delete commands
@ghost
Copy link
Author

ghost commented Feb 11, 2020

/milestone 0.8.0

@vdemeester vdemeester added this to the 0.8.0 🐯 milestone Feb 11, 2020
@danielhelfand danielhelfand added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 13, 2020
@danielhelfand danielhelfand mentioned this issue Feb 14, 2020
Merged
4 tasks
@danielhelfand danielhelfand mentioned this issue Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
0.8.0 🐯
Development

Successfully merging a pull request may close this issue.

Add Warning for --all Flags for Pipeline and Task Delete
2 participants
@vdemeester @danielhelfand