Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -t Shorthand for tkn task start --timeout Flag #743

Closed
danielhelfand opened this issue Feb 18, 2020 · 1 comment · Fixed by #751
Closed

Remove -t Shorthand for tkn task start --timeout Flag #743

danielhelfand opened this issue Feb 18, 2020 · 1 comment · Fixed by #751
Assignees
@waveywaves
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
0.9.0 🐺

Comments

@danielhelfand
Copy link
Member

Following up on discussions in #741, the -t shorthand for --timeout should be saved in case a flag is added that will be more frequently used than --timeout. The shorthand should not be removed until v0.9.0 and there should be notice given to users that -t will no longer be available in v0.9.0.

A warning message should be added in v0.8.0 similar to what was done for #702. There should also be a mention in release notes for v0.8.0 about the removal of the shorthand.

Removing the shorthand itself will simply be about changing -t for tkn task start to a blank string as is done for tkn pipeline start. This change should not break any testing as part of the CI process, but it will require running make man and make docs to update documentation.
@danielhelfand danielhelfand added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 18, 2020
@waveywaves
Copy link
Member

/assign

waveywaves added a commit to waveywaves/tekton-cli that referenced this issue Feb 24, 2020
@waveywaves
Remove -t timeout shorthand from tkn task start
5594863 
fixes tektoncd#743
@waveywaves waveywaves mentioned this issue Feb 24, 2020
Merged
4 tasks
@danielhelfand danielhelfand added this to the 0.9.0 🐺 milestone Feb 24, 2020
@danielhelfand danielhelfand mentioned this issue Feb 25, 2020
Merged
4 tasks
tekton-robot pushed a commit that referenced this issue Mar 2, 2020
@waveywaves @tekton-robot
Remove -t timeout shorthand from tkn task start
a25d288 
fixes #743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waveywaves waveywaves

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
0.9.0 🐺
Development

Successfully merging a pull request may close this issue.

cleanup (task/start) Remove -t timeout shorthand from tkn task start waveywaves/tekton-cli
2 participants
@waveywaves @danielhelfand