Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Warning Message for tkn task start --timeout #753

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Add Warning Message for tkn task start --timeout #753

merged 1 commit into from
Feb 26, 2020

Conversation

danielhelfand
Copy link
Member

Part of #730 and #743

Adding a warning message for expected changes for tkn task start --timeout in v0.9.0:

  • Removal of -t shorthand for --timeout
  • Changing flag from int to string to specify --timeout as a duration instead of in seconds

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

Add warning message for removal of tkn task start -t and changing --timeout to string

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2020
pradeepitm12
pradeepitm12 approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
vdemeester
vdemeester approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@danielhelfand is there an issue in the 0.9.0 milestone for it ? (if not we should create one to make sure we don't forget 🙃)

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@tekton-robot tekton-robot merged commit a55040f into tektoncd:master Feb 26, 2020
@danielhelfand danielhelfand mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vdemeester vdemeester

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danielhelfand @tekton-robot @vdemeester @pradeepitm12 @googlebot