-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ClusterTask Timeout from Int to String and Remove -t Shorthand #784
Comments
/assign @kadern0 |
@danielhelfand: GitHub didn't allow me to assign the following users: kadern0. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kadern0, I think you have to assign yourself to the issue. |
Done!
O mér., 11 de mar. de 2020 ás 13:42, Daniel Helfand (<
notifications@github.com>) escribiu:
… @kadern0 <https://github.com/kadern0>, I think you have to assign
yourself to the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#784?email_source=notifications&email_token=ADEHQTGCBW5HNCH43VUC573RG33BFA5CNFSM4LDB33V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEON5LHQ#issuecomment-597415326>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADEHQTDRR63SI6ZDTDKEAQTRG33BFANCNFSM4LDB33VQ>
.
|
/assign @kadern0 (this works as soon as you commented once, I think) |
Fixes issue tektoncd#784 Signed-off-by: Pablo Caderno <kaderno@gmail.com>
Fixes issue #784 Signed-off-by: Pablo Caderno <kaderno@gmail.com>
Closed by #793 |
Similar to #779,
tkn clustertask start --timeout
should be changed to a string duration format (i.e.1h30m2s
). Currently it is an integer that is used to specify a timeout in seconds.Similarly, the
-t
shorthand should be removed to keep consistency across all timeout commands.Unfortunately, this was missed in our previous round of deprecation/behavior change notices around timeout, so this change cannot take place until
v1.0.0
. We should log a warning message to users about this change in versionv0.9.0
. It can be the exact same format as what was used in #753.v0.9.0 Changes
Log warning message to user whenever
--timeout
is used withtkn ct start
:v1.0.0 Changes
The overall goal here will be to specify a Timeout via
tkn
as follows:The text was updated successfully, but these errors were encountered: