Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show account that created a PipelineRun or TaskRun #725

Closed
Conky5 opened this issue Feb 13, 2020 · 10 comments
Closed

Show account that created a PipelineRun or TaskRun #725

Conky5 opened this issue Feb 13, 2020 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Conky5
Copy link
Contributor

Conky5 commented Feb 13, 2020

It would be handy when doing a tkn pr describe ... or tkn tr describe ... to see which account started the run.

@danielhelfand
Copy link
Member

@Conky5 Could you please describe what you mean by account in this context?

Perhaps even include pseudo output of a tkn pr describe or tkn tr describe with this use case in mind?

@danielhelfand danielhelfand added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2020
@chmouel
Copy link
Member

chmouel commented Feb 13, 2020

Maybe the serviceaccount? Which we are not showing...

@danielhelfand
Copy link
Member

ServiceAccount should be available for both describe commands.

@chmouel
Copy link
Member

chmouel commented Feb 13, 2020

ah yes sorry, somehow i missed it 😅

@Conky5
Copy link
Contributor Author

Conky5 commented Feb 13, 2020

Thanks for the quick responses 😄. By account I mean the account that is authenticated to kubernetes when the run is created. For example if I create a pipeline run and then run a describe I see something like:

$ tkn pr describe example-9zrts
Name:              example-9zrts
Namespace:         example
Pipeline Ref:      example-pipeline
Service Account:   default

🌡️   Status

STARTED        DURATION    STATUS
19 hours ago   4 seconds   Succeeded

📦 Resources

 No resources

⚓ Params

 NAME             VALUE
 ∙ my-parameter

🗂  Taskruns

 NAME                                       TASK NAME   STARTED        DURATION    STATUS
 ∙ example-9zrts-something-wl4lc   something   19 hours ago   4 seconds   Succeeded

Other folks who run a describe like that do not know who started it, let's say conky5@example.com is my account. Pseudo output that includes this information could look like:

$ tkn pr describe example-9zrts
Name:              example-9zrts
Namespace:         example
Pipeline Ref:      example-pipeline
Service Account:   default
User:              conky5@example.com

🌡️   Status

STARTED        DURATION    STATUS
19 hours ago   4 seconds   Succeeded

📦 Resources

 No resources

⚓ Params

 NAME             VALUE
 ∙ my-parameter

🗂  Taskruns

 NAME                                       TASK NAME   STARTED        DURATION    STATUS
 ∙ example-9zrts-something-wl4lc   something   19 hours ago   4 seconds   Succeeded

@danielhelfand
Copy link
Member

@Conky5 Thanks for the clarification! I think this makes sense. I am wondering if this would require some work in pipeline as well to capture this data on the PipelineRun/TaskRun? The question would be how to make sure it persists on the created object cause we can definitely capture the user from the CLI.

cc @chmouel @vdemeester

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 13, 2020
@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants