Enable auto-select support in ClusterTask/TaskRun if only one is present #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/L
vinamra28
force-pushed
the
vinamra28/auto-select-describe
branch
from
ab95c19
to
06740b2
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
vinamra28
force-pushed
the
vinamra28/auto-select-describe
branch
from
06740b2
to
4a8df0f
Compare
|
The following is the coverage report on the affected files.
|
vinamra28
force-pushed
the
vinamra28/auto-select-describe
branch
from
4a8df0f
to
d191e82
Compare
|
The following is the coverage report on the affected files.
|
vinamra28
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on the affected files.
|
danielhelfand
suggested changes
Sep 11, 2020
When only one clustertask is present then instead of prompting to user to select the clustertask at the time of running the clustertask describe command then clustertask will be autoselected and the output will be displayed. Also extracted to allClusterTaskNames function from pkg/cmd/clustertask/delete.go to pkg/clustertask/clustertask.go in order to maintain code consistency and also added unit tests for the same. Signed-off-by: vinamra28 <vinjain@redhat.com>
vinamra28
force-pushed
the
vinamra28/auto-select-describe
branch
from
626c941
to
31b927f
Compare
|
The following is the coverage report on the affected files.
|
When only one taskrun is present then instead of prompting to user to select the taskrun at the time of running the taskrun describe command it will be autoselected and the output will be displayed. Signed-off-by: vinamra28 <vinjain@redhat.com>
vinamra28
force-pushed
the
vinamra28/auto-select-describe
branch
from
31b927f
to
5b2e459
Compare
|
The following is the coverage report on the affected files.
|
danielhelfand
approved these changes
Sep 14, 2020
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
danielhelfand
added a commit
that referenced
this pull request
Sep 30, 2020
#1167 | [Daniel Helfand] update condition tests from test builders to structs | 2020/09/16-11:10 #1154 | [vinamra28] Enable auto-select support in ClusterTaskDescribe if only one is present | 2020/09/16-17:00 #1154 | [vinamra28] Enable auto-select support in TaskRunDescribe if only one is present | 2020/09/16-17:00 #1173 | [Daniel Helfand] update README versions for v0.12.1 | 2020/09/16-17:21 #1176 | [Bart] Artwork/Logo added to the top of the README. | 2020/09/16-18:14 #1172 | [Chmouel Boudjnah] Fix rpm build for release | 2020/09/17-14:34 #1168 | [Daniel Helfand] update clustertask tests from test builders to structs | 2020/09/18-13:26 #1177 | [Vincent Demeester] tests: import pipeline internal builders 🏒 | 2020/09/18-17:31 #1179 | [vinamra28] Use --prefix-name option for tkn clustertask start | 2020/09/18-23:07 #1182 | [Daniel Helfand] update pipelineresource tests from test builders to structs | 2020/09/21-14:29 null | [Vincent Demeester] Remove release-note block indentation in PR template 🌮 | 2020/09/22-11:57 null | [savitaashture] Modify tkn version to accept ldflag and namespace flag | 2020/09/24-10:14 null | [savitaashture] Fix deployment fetch issue for multiple namespaces | 2020/09/25-11:54 null | [PuneetPunamiya] This patch fixes: | 2020/09/28-19:27 null | [Divyansh42] Modify tkn version output to hide Triggers and Dashboard version if they are not installed and added required unit tests. | 2020/09/29-04:57 null | [Piyush Garg] Bump pipeline and triggers dep | 2020/09/29-13:55 null | [Divyansh42] Enable auto-select support in pipelineDescribe if only one pipeline is present | 2020/09/29-17:29 null | [vinamra28] Add --use-taskrun for ClusterTask start | 2020/09/30-11:08 null | [Divyansh42] Enable auto select support in PipelineRunDescribe if only one PipelineRun is present | 2020/09/30-13:13 Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
clustertaskis present then instead of prompting to user to select theclustertaskat the time of running theclustertask describecommand thenclustertaskwill be autoselected and the output will be displayed.taskrunis present then instead of prompting to user to select thetaskrunat the time of running thetaskrun describecommand thentaskrunwill be autoselected and the output will be displayed.allClusterTaskNamesfunction frompkg/cmd/clustertask/delete.gotopkg/clustertask/clustertask.goin order to maintain the code consistency and also added unit tests for it.Closes #1112
Signed-off-by: vinamra28 vinjain@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes