Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove go11modules export instructions in README #1530

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Remove go11modules export instructions in README #1530

merged 1 commit into from
Mar 14, 2022

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Mar 14, 2022 •
edited
Loading

it's been not needed since around go11 (since auto) and on by default
since go16

see https://maelvls.dev/go111module-everywhere/

Release Note

NONE

Signed-off-by: Chmouel Boudjnah chmouel@redhat.com

@chmouel
Remove go11modules export instructions in README
3bc6895 
it's been not needed since around go11 (since auto) and on by default
since go16

see https://maelvls.dev/go111module-everywhere/

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 14, 2022
@chmouel
Copy link
Member Author

chmouel commented Mar 14, 2022

/retest

@chmouel
Copy link
Member Author

chmouel commented Mar 14, 2022

hub certificate is down so we are gettings thing like :

image

🤦🏻

@vdemeester
Copy link
Member

/retest

@vdemeester
Copy link
Member

@chmouel we may want to deploy a local/test hub for the build 😛

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@chmouel
Copy link
Member Author

chmouel commented Mar 14, 2022

@vdemeester i don't think that's the issue, it's the links checker bugging on non valid https url

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2022
@tekton-robot tekton-robot merged commit 95cc224 into tektoncd:main Mar 14, 2022
pradeepitm12 added a commit that referenced this pull request Mar 24, 2022
@pradeepitm12
New version v0.23.1
024203f 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this pull request Mar 24, 2022
@pradeepitm12
New version v0.23.1
ffb5b56 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this pull request Mar 24, 2022
@pradeepitm12
New version v0.23.1
af5ca5f 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this pull request Mar 24, 2022
@pradeepitm12
New version v0.23.1
a64bd14 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this pull request Mar 25, 2022
@pradeepitm12
New version v0.23.1
d4f31d6 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this pull request Mar 25, 2022
@pradeepitm12
New version v0.23.1
1174dec 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this pull request Mar 25, 2022
@pradeepitm12
New version v0.23.1
6fcd7c4 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12 added a commit that referenced this pull request Mar 25, 2022
@pradeepitm12
New version v0.23.1
ffaca88 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
piyush-garg added a commit that referenced this pull request Mar 25, 2022
@piyush-garg
New version v0.23.1
5147967 
#1525 | [Piyush Garg] Update docs to latest version 0.23.0 | 2022/03/09-17:25
#1528 | [Chmouel Boudjnah] generate universal binaries for osx | 2022/03/11-10:28
#1529 | [PuneetPunamiya] Adds namespace where operator is installed | 2022/03/11-14:06
#1530 | [Chmouel Boudjnah] Remove go11modules export instructions in README | 2022/03/14-15:49
#1526 | [Chmouel Boudjnah] Add information about arch package | 2022/03/14-16:17
#1523 | [Vincent Demeester] ROADMAP.md: update it to reflect 2022 goals | 2022/03/15-11:18
#1467 | [mathew-fleisch] Go compile darwin-arm64 in makefile for m1 macs | 2022/03/15-13:04
#1520 | [jbpratt] parse full duration for time formatting | 2022/03/15-16:12
#1531 | [Chmouel Boudjnah] Add "tkn taskrun export" | 2022/03/18-09:46
#1538 | [Chmouel Boudjnah] update to cobra 1.4.0 | 2022/03/18-11:42
null | [PuneetPunamiya] Updates the configMap name for Operator version | 2022/03/18-13:01
null | [Chmouel Boudjnah] Add -o name to pipeline start | 2022/03/22-11:32
null | [Piyush Garg] This will fix the version command failing for chain and operator | 2022/03/23-12:16
null | [Pradeep Kumar] fix error while deleting pr without status | 2022/03/24-07:16

Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chmouel @vdemeester @tekton-robot @piyush-garg