-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use bundle with no kubeconfig #1557
Conversation
It should be possible to list and push bundles without having to have a valid kubeconfig. This change makes sure that no error is thrown if no kubeconfig is found while invoking `tkn bundle`.
|
Hi @davidmogar. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
/retest |
Changes
It should be possible to list and push bundles without having to have a valid kubeconfig. This change makes sure that no error is thrown if no kubeconfig is found while invoking
tkn bundle
.Submitter Checklist
Note: I think tests are not needed for this one. It also follows a very similar commit
make check
make generated
Release Notes