Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use bundle with no kubeconfig #1557

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

davidmogar
Copy link
Contributor

@davidmogar davidmogar commented Apr 27, 2022

Changes

It should be possible to list and push bundles without having to have a valid kubeconfig. This change makes sure that no error is thrown if no kubeconfig is found while invoking tkn bundle.

Submitter Checklist

  • Includes tests (if functionality changed/added)
    Note: I think tests are not needed for this one. It also follows a very similar commit
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

NONE

It should be possible to list and push bundles without having to have a
valid kubeconfig. This change makes sure that no error is thrown if no
kubeconfig is found while invoking `tkn bundle`.
@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 27, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 27, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: davidmogar / name: David Moreno García (c037100)

@tekton-robot
Copy link
Contributor

Hi @davidmogar. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2022
@vdemeester
Copy link
Member

/ok-to-test
/cc @tektoncd/cli-maintainers

@tekton-robot tekton-robot requested a review from a team June 8, 2022 17:57
@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2022
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 8, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vdemeester,vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinamra28
Copy link
Member

/retest

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@piyush-garg
Copy link
Contributor

/retest

@tekton-robot tekton-robot merged commit f9caf48 into tektoncd:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants