Improve tkn chain log format
#1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
Prior to this commit, `tkn chain` logs look like:
```
$ tkn chains payload build-push-run-output-image-p229w
sync /dev/stderr: invalid argument
{"level":"info","ts":1654352100.0164135,"caller":"tekton/tekton.go:134","msg":"Retrieving payload on TaskRun default/build-push-run-output-image-p229w"}
{"level":"info","ts":1654352100.0164497,"caller":"tekton/tekton.go:86","msg":"Retrieving annotation \"chains.tekton.dev/payload-taskrun-6e2f020b-7d50-4022-8064-049680f72d32\" on TaskRun default/build-push-run-output-image-p229w"}
No payloads found for taskrun build-push-run-output-image-p229w
```
and after this commit they look like:
```
$ ./tkn chains payload build-push-run-output-image-p229w
sync /dev/stderr: invalid argument
Retrieving payload on TaskRun default/build-push-run-output-image-p229w
Retrieving annotation "chains.tekton.dev/payload-taskrun-6e2f020b-7d50-4022-8064-049680f72d32" on TaskRun default/build-push-run-output-image-p229w
No payloads found for taskrun build-push-run-output-image-p229w
```
which is more in line with how `tkn` logs look like in general.
concaf
force-pushed
the
concaf/fix/chains-fixes
branch
from
e9b714a
to
9a23a2b
Compare
|
/retest |
|
/approve |
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
tkn chainlogs look like:and after this commit they look like:
which is more in line with how
tknlogs look like in general.Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes