Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore zap logger sync error #1588

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

concaf
Copy link
Contributor

@concaf concaf commented Jun 4, 2022

Prior to this commit, this is how all tkn chains output starts like:

$ tkn chain payload build-push-run-output-image-p229w
sync /dev/stderr: invalid argument
...
...

This commit gets rid of the sync /dev/stderr: invalid argument error
by ignoring it, which is safe: see
uber-go/zap#328

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Prior to this commit, this is how all `tkn chains` output starts like:

```
$ tkn chain payload build-push-run-output-image-p229w
sync /dev/stderr: invalid argument
...
...
```

This commit gets rid of the `sync /dev/stderr: invalid argument` error
by ignoring it, which is safe: see
uber-go/zap#328
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 4, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2022
@tekton-robot
Copy link
Contributor

@concaf: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

@concaf: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 4, 2022
@concaf
Copy link
Contributor Author

concaf commented Jun 4, 2022

/release-note-none

@concaf
Copy link
Contributor Author

concaf commented Jun 5, 2022

/test pull-tekton-cli-integration-tests

@concaf
Copy link
Contributor Author

concaf commented Jun 5, 2022

/retest

@piyush-garg
Copy link
Contributor

/approve
/retest

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [piyush-garg,pradeepitm12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 58b2db8 into tektoncd:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants