Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed apt-key for deb-based install instructions #1653

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Removed apt-key for deb-based install instructions #1653

merged 2 commits into from
Jul 27, 2022

Conversation

jgreenbow-userful
Copy link
Contributor

@jgreenbow-userful jgreenbow-userful commented Jul 22, 2022 •
edited
Loading

Changes

Updated gpg key import for PPA

Users may receive a warning every apt-get update due to apt-key deprecation
W: http://ppa.launchpad.net/tektoncd/cli/ubuntu/dists/eoan/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details.
Users on older versions of apt may require the bare binary key, instead of the keybox

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 22, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 22, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jgreenbow-userful / name: Jacob Greenbow (0e1cd55)

@tekton-robot
Copy link
Contributor

Hi @jgreenbow-userful. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2022
@chmouel
Copy link
Member

chmouel commented Jul 25, 2022

/ok-to-test

nice thank you

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2022
@chmouel
Copy link
Member

chmouel commented Jul 25, 2022

(sorry about the CLA but we will need it to be signed to be able to merge this pr)

@jgreenbow-userful
Copy link
Contributor Author

@chmouel no worries, I was just contributing the fix I tracked down for apt spam. I didn't have time on Friday to amend my commit message, or sign the CLA once I noted its existence in the contributer guide. I'll look at this later 👍

@jgreenbow-userful
Removed apt-key for deb-based install instructions
0e1cd55 
If apt-key is used to import the gpg key for the tektoncd PPA, users
receive a warning every time they issue an `apt update` due to apt-key
deprecation.

Instead, download the tektoncd key to /etc/apt/keyrings/ (as per
sources.list(5)) and use the signed-by option in sources.list. This is
the currently documented replacement for apt-key usage.

Warning shown as:
W: http://ppa.launchpad.net/tektoncd/cli/ubuntu/dists/eoan/InRelease:
Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see
the DEPRECATION section in apt-key(8) for details.
@jgreenbow-userful jgreenbow-userful changed the title Updated gpg key import for PPA Removed apt-key for deb-based install instructions Jul 25, 2022
@jgreenbow-userful jgreenbow-userful marked this pull request as ready for review July 25, 2022 19:26
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2022
@chmouel
Copy link
Member

chmouel commented Jul 26, 2022

/retest

1 similar comment
@vinamra28
Copy link
Member

/retest

@jgreenbow-userful
Copy link
Contributor Author

Hey there, I am totally new to open source contribution. I sync'd this branch with tektoncd:main, but that has produced an (unecessary) merge commit. My guess is that I should rebase my tiny branch onto tektoncd:main and let it test through again. Is it kosher to issue rewrites to my fork during a PR review, or should I preserve the history of syncing up my branch and keep the merge commit in?

@chmouel
Copy link
Member

chmouel commented Jul 27, 2022 •
edited
Loading

I think you good, it doesn't conflict or CI will tell you it needs a merge/rebase.

Thanks for your contribution

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@tekton-robot tekton-robot merged commit ec52449 into tektoncd:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@hrishin hrishin Awaiting requested review from hrishin

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@chmouel chmouel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgreenbow-userful @tekton-robot @chmouel @vinamra28