Fix incomplete TaskRuns being deleted when --ignore-running=true

[colinodell]

Changes

Fixes #1707 by replacing the logic used to determine if a TaskRun is "running".

Prior to this PR, we used an allowlist of reasons like Running, Pending, and Started. This did not account for some states where the TaskRun is still running, like when cancellation has been requested (but not completed), or when the TaskRun encounters a non-permanent error and is still running (like ExceededResourceQuota).

This PR fixes this by instead checking for the presence of a completionTime which would indicate that the TaskRun is no longer in a running or about-to-run state.

Additionally, to help confirm these changes work as expected in the test suite, output messages that previously said something like All TaskRuns were deleted were updated to include the actual number of TaskRuns deleted.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

- Fix --ignore-running=true unexpectedly deleting some TaskRuns in incomplete states
- Ensure TaskRun deletion command always shows the number of deleted objects

[tekton-robot]

Hi @colinodell. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: colinodell / name: Colin O'Dell (abb5704, 618868f, 3be28b5, 735d3bd)

[vdemeester]

/ok-to-test
/cc @pradeepitm12 @piyush-garg

[piyush-garg]

@colinodell PR looks good, can you please squash the commits into 1

/lgtm

[colinodell]

Thanks! I've squashed the commits as requested :)

[piyush-garg]

/lgtm

[pradeepitm12]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pradeepitm12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment