Query PipelineResources only if needed #1725
Conversation
Change the `tkn pipeline start` command to only query for PipelineResources in the cluster if the Pipeline uses Resources. As PipelineResources are marked as deprecated, some cluster maintainers may decide to not install this CRD altogether. Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
|
/retest I can't tell exactly what the failure is. Maybe it's a random failure. For posterity, the failed tests were: |
|
Ok, I see other open PRs have the same test failure. Probably broken in main. |
|
@lcarva yeah, @piyush-garg is looking into it (tektoncd/pipeline#5537). |
|
/retest |
|
/lgtm |
|
I still see the same test error as before. Maybe tektoncd/pipeline#5537 is not completely done? I rebased my branch with main, but there are no changes. |
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
Change the
tkn pipeline startcommand to only query for PipelineResources in the cluster if the Pipeline uses Resources. As PipelineResources are marked as deprecated, some cluster maintainers may decide to not install this CRD altogether.Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedRelease Notes