Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go and golangci-lint version #1746

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

pradeepitm12
Copy link
Contributor

this updates go and golangci-lint verion to 1.18.7 and 1.47.3 respectively to fix the release script

Signed-off-by: Pradeep Kumar pradkuma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

this updates go and golangci-lint verion to 1.18.7 and 1.47.3
respectively to fix the release script

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 11, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@tekton-robot tekton-robot merged commit a4488c9 into tektoncd:main Oct 12, 2022
vinamra28 added a commit that referenced this pull request Oct 19, 2022
#1743 | [dependabot[bot]] Bump gotest.tools/v3 from 3.3.0 to 3.4.0 | 2022/10/12-09:47
#1744 | [dependabot[bot]] Bump google.golang.org/grpc from 1.49.0 to 1.50.0 | 2022/10/12-09:47
#1746 | [Pradeep Kumar] update go and golangci-lint version | 2022/10/12-10:27
#1747 | [Andrea Frittoli] Add releases.md for the CLI | 2022/10/12-10:27
#1748 | [Pradeep Kumar] Update README for v0.27.0 | 2022/10/12-10:27
#1752 | [Andrea Frittoli] Actually add a releases.md | 2022/10/12-13:35
#1751 | [Seongpyo Hong] Add timestamps option to show log with timestamp | 2022/10/12-15:37
#1753 | [dependabot[bot]] Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 | 2022/10/13-09:25
#1753 | [Piyush Garg] Get rid of deprecated cobra functions | 2022/10/13-09:25
#1745 | [Tomas Dabašinskas] Update .goreleaser.yml | 2022/10/17-17:11
null | [dependabot[bot]] Bump github.com/docker/docker | 2022/10/17-19:49
null | [dependabot[bot]] Bump github.com/docker/cli | 2022/10/18-09:13
null | [dependabot[bot]] Bump google.golang.org/grpc from 1.50.0 to 1.50.1 | 2022/10/18-09:55

Signed-off-by: vinamra28 <jvinamra776@gmail.com>
vinamra28 added a commit that referenced this pull request Oct 19, 2022
#1743 | [dependabot[bot]] Bump gotest.tools/v3 from 3.3.0 to 3.4.0 | 2022/10/12-09:47
#1744 | [dependabot[bot]] Bump google.golang.org/grpc from 1.49.0 to 1.50.0 | 2022/10/12-09:47
#1746 | [Pradeep Kumar] update go and golangci-lint version | 2022/10/12-10:27
#1747 | [Andrea Frittoli] Add releases.md for the CLI | 2022/10/12-10:27
#1748 | [Pradeep Kumar] Update README for v0.27.0 | 2022/10/12-10:27
#1752 | [Andrea Frittoli] Actually add a releases.md | 2022/10/12-13:35
#1751 | [Seongpyo Hong] Add timestamps option to show log with timestamp | 2022/10/12-15:37
#1753 | [dependabot[bot]] Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 | 2022/10/13-09:25
#1753 | [Piyush Garg] Get rid of deprecated cobra functions | 2022/10/13-09:25
#1745 | [Tomas Dabašinskas] Update .goreleaser.yml | 2022/10/17-17:11
null | [dependabot[bot]] Bump github.com/docker/docker | 2022/10/17-19:49
null | [dependabot[bot]] Bump github.com/docker/cli | 2022/10/18-09:13
null | [dependabot[bot]] Bump google.golang.org/grpc from 1.50.0 to 1.50.1 | 2022/10/18-09:55

Signed-off-by: vinamra28 <jvinamra776@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants