pipeline start supports taskRunSpec argument #1969

haedaal · 2023-03-31T01:23:15Z

Changes

Add taskRunSpec argument on tkn pipeline start

closes #951

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run the code checkers with make check
Regenerate the manpages, docs and go formatting with make generated
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

tekton-robot · 2023-03-31T01:23:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

linux-foundation-easycla · 2023-03-31T01:23:20Z

The committers listed above are authorized under a signed CLA.

✅ login: haedaal / name: Minjae Kim (feb0a01, bbe9740, 1e5023f, aabe9e6, 095983a, 4dba6ad)

tekton-robot · 2023-03-31T01:23:24Z

Hi @haedaal. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haedaal · 2023-03-31T10:27:01Z

pkg/cmd/pipeline/testdata/taskrunspec.yaml

@@ -0,0 +1,6 @@
+- pipelineTaskName: unit-test-task


I referred #1088 writing this pr, and it's mostly the same but here hardcoded pipelineTaskName maybe seems fragile to future change. maybe ok?

@haedaal what could be the other options ? multiple flags --tasrun-spec, one fore each task ? what else ?
I think the one is ok, but I won't if there could be other alternative to look into.

may be we can add a check in parsing to have multiple tasks

@vdemeester I feel like there's no better alternatives, as it looks exactly same as k8s spec. I think simplicity is worth a bit of fragility.

haedaal · 2023-03-31T10:30:38Z

test/e2e/pipeline/pipeline_test.go

@@ -305,6 +305,23 @@ Waiting for logs to be available...
 		}
 	})

+	t.Run("Start PipelineRun with --task-run-spec", func(t *testing.T) {


When I try to run e2e test, I'm seeing following log

package github.com/tektoncd/cli/test/e2e/pipeline: build constraints exclude all Go files in /Users/minjaekim/workspace/oss/cli/test/e2e/pipeline

So I've written this code, but never have run it. What should I do?

pkg/cmd/pipeline/start.go

vdemeester · 2023-04-07T09:18:38Z

pkg/cmd/pipeline/testdata/taskrunspec.yaml

@@ -0,0 +1,6 @@
+- pipelineTaskName: unit-test-task


@haedaal what could be the other options ? multiple flags --tasrun-spec, one fore each task ? what else ?
I think the one is ok, but I won't if there could be other alternative to look into.

pkg/pods/testdata/taskrunspec-not-yaml

vdemeester · 2023-04-07T09:21:19Z

/ok-to-test

piyush-garg · 2023-04-07T16:48:27Z

pkg/cmd/pipeline/testdata/taskrunspec.yaml

@@ -0,0 +1,6 @@
+- pipelineTaskName: unit-test-task


need license header here

fixed @ 0663311

piyush-garg · 2023-04-07T16:48:41Z

pkg/pods/task_run_spec.go

@@ -0,0 +1,39 @@
+// Copyright © 2020 The Tekton Authors.


this should be 2023

fixed @ 5f4ffd5

piyush-garg · 2023-04-07T16:48:53Z

pkg/pods/task_run_spec_test.go

@@ -0,0 +1,98 @@
+// Copyright © 2020 The Tekton Authors.


this should be 2023

fixed @ 5f4ffd5

piyush-garg · 2023-04-07T16:49:05Z

pkg/pods/testdata/taskrunspec-not-yaml

@@ -0,0 +1,20 @@
+# Copyright 2020 The Tekton Authors.


this should be 2023

fixed @ 5f4ffd5

piyush-garg · 2023-04-07T16:49:20Z

pkg/pods/testdata/taskrunspec-typo.yaml

@@ -0,0 +1,20 @@
+# Copyright 2020 The Tekton Authors.


this should be 2023

fixed @ 5f4ffd5

piyush-garg · 2023-04-07T16:49:32Z

pkg/pods/testdata/taskrunspec.yaml

@@ -0,0 +1,20 @@
+# Copyright 2020 The Tekton Authors.


this should be 2023

fixed @ 5f4ffd5

piyush-garg · 2023-04-07T16:54:52Z

test/e2e/pipeline/pipeline_test.go

+		tkn.MustSucceed(t, "pipeline", "start", tePipelineName,
+			"-p=filename=output",
+			"-w=name=shared-data,emptyDir=",
+			"--taskrun-spec="+helper.GetResourcePath("/taskrunspec/taskrunspec.yaml"),


the path seems incorrect here

fixed @ ede2079

piyush-garg · 2023-04-10T06:42:49Z

/retest

tekton-robot · 2023-07-09T07:28:06Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot · 2023-08-08T08:16:34Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

piyush-garg · 2023-08-16T08:10:24Z

/remove-lifecycle rotten

piyush-garg · 2024-06-21T08:47:17Z

@haedaal

Would love to get this in, can you please squash the commit into one, with nice commit msg.

piyush-garg · 2024-06-23T18:37:14Z

/test all

tekton-robot · 2024-06-23T18:55:35Z

@haedaal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-cli-unit-tests	`5f4ffd5`	link	true	`/test pull-tekton-cli-unit-tests`
pull-tekton-cli-build-tests	`5f4ffd5`	link	true	`/test pull-tekton-cli-build-tests`
pull-tekton-cli-integration-tests	`5f4ffd5`	link	true	`/test pull-tekton-cli-integration-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

poc

feb0a01

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2023

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 31, 2023

tekton-robot requested review from chmouel and pradeepitm12 March 31, 2023 01:23

tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2023

tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2023

haedaal added 3 commits March 31, 2023 15:48

make docs

bbe9740

Add unittests

1e5023f

add e2e test

aabe9e6

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2023

haedaal commented Mar 31, 2023

View reviewed changes

mirror podtemplate

095983a

piyush-garg reviewed Mar 31, 2023

View reviewed changes

pkg/cmd/pipeline/start.go Outdated Show resolved Hide resolved

use --taskrun-spec

4dba6ad

vdemeester reviewed Apr 7, 2023

View reviewed changes

vdemeester marked this pull request as ready for review April 7, 2023 09:21

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2023

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2023

piyush-garg reviewed Apr 7, 2023

View reviewed changes

haedaal added 3 commits April 8, 2023 17:56

fix resource path

ede2079

add license header

0663311

fix year of license headers

5f4ffd5

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2023

tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 8, 2023

tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 16, 2023

vinamra28 mentioned this pull request Aug 19, 2023

Support for taskRunSpecs Property of a PipelineRun with tkn pipeline start #951

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pipeline start supports taskRunSpec argument #1969

pipeline start supports taskRunSpec argument #1969

haedaal commented Mar 31, 2023 •

edited by vinamra28

Loading

tekton-robot commented Mar 31, 2023

linux-foundation-easycla bot commented Mar 31, 2023 •

edited

Loading

tekton-robot commented Mar 31, 2023

haedaal Mar 31, 2023

vdemeester Apr 7, 2023

piyush-garg Apr 7, 2023

haedaal Apr 8, 2023

haedaal Mar 31, 2023

vdemeester Apr 7, 2023

vdemeester commented Apr 7, 2023

piyush-garg Apr 7, 2023

haedaal Apr 8, 2023

piyush-garg Apr 7, 2023

haedaal Apr 8, 2023

piyush-garg Apr 7, 2023

haedaal Apr 8, 2023

piyush-garg Apr 7, 2023

haedaal Apr 8, 2023

piyush-garg Apr 7, 2023

haedaal Apr 8, 2023

piyush-garg Apr 7, 2023

haedaal Apr 8, 2023

piyush-garg Apr 7, 2023

haedaal Apr 8, 2023

piyush-garg commented Apr 10, 2023

tekton-robot commented Jul 9, 2023

tekton-robot commented Aug 8, 2023

piyush-garg commented Aug 16, 2023

piyush-garg commented Jun 21, 2024

piyush-garg commented Jun 23, 2024

tekton-robot commented Jun 23, 2024

pipeline start supports taskRunSpec argument #1969

Are you sure you want to change the base?

pipeline start supports taskRunSpec argument #1969

Conversation

haedaal commented Mar 31, 2023 • edited by vinamra28 Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Mar 31, 2023

linux-foundation-easycla bot commented Mar 31, 2023 • edited Loading

tekton-robot commented Mar 31, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vdemeester commented Apr 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

piyush-garg commented Apr 10, 2023

tekton-robot commented Jul 9, 2023

tekton-robot commented Aug 8, 2023

piyush-garg commented Aug 16, 2023

piyush-garg commented Jun 21, 2024

piyush-garg commented Jun 23, 2024

tekton-robot commented Jun 23, 2024

haedaal commented Mar 31, 2023 •

edited by vinamra28

Loading

linux-foundation-easycla bot commented Mar 31, 2023 •

edited

Loading