Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the README.md with prerequisites required for running the tests. #2226

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Updated the README.md with prerequisites required for running the tests. #2226

merged 1 commit into from
Feb 8, 2024

Conversation

Senjuti256
Copy link
Contributor

@Senjuti256 Senjuti256 commented Jan 29, 2024 •
edited by piyush-garg
Loading

Changes

I have updated the README.md in the test folder with some prerequisites required for running the tests.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 29, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Senjuti256 / name: Senjuti De (b342eaf)

@tekton-robot
Copy link
Contributor

Hi @Senjuti256. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 29, 2024
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2024
vinamra28
vinamra28 reviewed Feb 6, 2024
View reviewed changes
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated

### Running

End to end tests live in this directory. By default `go test` will not run [the end to end tests](#end-to-end-tests),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End to end tests live in this directory.

let's add a hyperlink to this keyword ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @vinamra28 doing it.

test/README.md Outdated Show resolved Hide resolved
@Senjuti256 Senjuti256 force-pushed the e2e-doc branch 2 times, most recently from d7b5483 to e072160 Compare February 8, 2024 07:54
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2024
vinamra28
vinamra28 reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senjuti256, can you please squash the commits?
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@Senjuti256
Copy link
Contributor Author

Done @vinamra28 @vdemeester . I have squashed all the commits but the ok-to-test label got removed.

@vinamra28
Copy link
Member

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@tekton-robot tekton-robot merged commit c62b030 into tektoncd:main Feb 8, 2024
8 checks passed
piyush-garg added a commit that referenced this pull request Feb 13, 2024
@piyush-garg
New version v0.35.1
4854f37 
#2239 | [Piyush Garg] Bump docs to latest v0.35.0 | 2024/02/08-03:17
#2226 | [Senjuti De] Refactored README.md file. | 2024/02/08-10:03
#2240 | [dependabot[bot]] Bump golang.org/x/term from 0.16.0 to 0.17.0 | 2024/02/08-21:07
#2241 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.55.2 to 1.56.0 in /tools | 2024/02/08-21:37
#2242 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.56.0 to 1.56.1 in /tools | 2024/02/12-04:57
#2244 | [Piyush Garg] Fix triggertemplate describe command breaks backward compatibility | 2024/02/12-17:51

Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Senjuti256 @tekton-robot @vdemeester @vinamra28