Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labeling support to tkn bundle push #2257

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Add labeling support to tkn bundle push #2257

merged 1 commit into from
Feb 27, 2024

Conversation

zregvart
Copy link
Contributor

Changes

When pushing the bundle -l or --label can be provided to set labels in the config JSON of the image.

Fixes #2256

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

Added support for setting bundle image labels

@zregvart
Add labeling support to tkn bundle push
23183c1 
When pushing the bundle `-l` or `--label` can be provided to set labels
in the config JSON of the image.

Fixes tektoncd#2256
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2024
@tekton-robot
Copy link
Contributor

Hi @zregvart. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2024
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2024
@piyush-garg
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
vinamra28
vinamra28 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [piyush-garg,vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 4877295 into tektoncd:main Feb 27, 2024
8 checks passed
@zregvart zregvart deleted the issue/2256 branch February 27, 2024 10:17
vinamra28 added a commit that referenced this pull request Mar 20, 2024
@vinamra28
New version v0.36.0
e0dddfb 
#2246 | [Piyush Garg] Bump readme for v0.35.1 | 2024/02/13-15:05
#2247 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.56.0 to 0.56.1 | 2024/02/14-15:21
#2248 | [dependabot[bot]] Bump knative.dev/serving from 0.38.6 to 0.39.0 | 2024/02/14-20:35
#2249 | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.26.13 to 0.26.14 | 2024/02/15-05:45
#2250 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.56.1 to 1.56.2 in /tools | 2024/02/19-06:07
#2254 | [dependabot[bot]] Bump go.uber.org/zap from 1.26.0 to 1.27.0 | 2024/02/21-15:09
#2253 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.56.1 to 0.57.0 | 2024/02/21-15:53
#2255 | [Senjuti De] Drafted a basic doc for tkn-plugins | 2024/02/26-11:15
#2257 | [Zoran Regvart] Add labeling support to `tkn bundle push` | 2024/02/27-06:07
#2251 | [Piyush Garg] Fix logs command not showing logs | 2024/02/27-07:03
null | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.8.1 to 1.8.2 | 2024/02/28-07:25
null | [Piyush Garg] Prepare setup for moving e2e to kind | 2024/03/01-17:45
null | [Piyush Garg] Bump golangci-lint to v0.56.2 | 2024/03/05-08:17
null | [dependabot[bot]] Bump golang.org/x/term from 0.17.0 to 0.18.0 | 2024/03/11-10:23
null | [dependabot[bot]] Bump github.com/docker/docker | 2024/03/11-11:57
null | [dependabot[bot]] Bump github.com/go-jose/go-jose/v3 from 3.0.2 to 3.0.3 | 2024/03/11-11:57
null | [dependabot[bot]] Bump github.com/docker/cli | 2024/03/11-13:17
null | [dependabot[bot]] Bump github.com/cloudevents/sdk-go/v2 from 2.14.0 to 2.15.2 | 2024/03/11-14:17
null | [dependabot[bot]] Bump gopkg.in/go-jose/go-jose.v2 from 2.6.1 to 2.6.3 | 2024/03/11-14:17
null | [dependabot[bot]] Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /tools | 2024/03/14-02:37
null | [dependabot[bot]] Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 | 2024/03/14-03:43
null | [Piyush Garg] Bump golang to 1.21 as minimum requirement | 2024/03/14-10:31
null | [dependabot[bot]] Bump github.com/google/go-containerregistry from 0.19.0 to 0.19.1 | 2024/03/15-06:42
null | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.26.14 to 0.26.15 | 2024/03/15-19:18

Signed-off-by: vinamra28 <jvinamra776@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for providing labels in tkn bundle push
5 participants
@zregvart @tekton-robot @vdemeester @piyush-garg @vinamra28