Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.13 support #300

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Go 1.13 support #300

merged 2 commits into from
Sep 9, 2019

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Sep 9, 2019 •
edited
Loading

From:

hashicorp/terraform#22664 (comment)

change the replace of the thrift version

Closes #298

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2019
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Sep 9, 2019
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 9, 2019
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2019
@chmouel
Use a older version of thrift
464c857 
Since the newest one would not work with go1.13

Not sure if i understand everyhting but it seems to work on 1.12 and 1.13 (and
that's what they do as well here
hashicorp/terraform#22664 (comment))

Closes tektoncd#298

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2019
@chmouel
Don't run go mod vendor on every build
5296568 
This confuses go1.13 and go1.12.

One one side you have an overachiever child wanting to rewrite the whole vendor
directory and on the other side we have an old geezer that doesn't want to hear
anything of it, mixed with a CIA acting like child affected by the inflexible
syndrome and we end up in this situation.
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2019
vdemeester
vdemeester approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 14a71e9 into tektoncd:master Sep 9, 2019
@chmouel chmouel deleted the update-to-1.13 branch September 9, 2019 13:52
chmouel added a commit that referenced this pull request Sep 26, 2019
@chmouel
New version v0.4.0
950a5fe 
#290 | [Chmouel Boudjnah] Add rainbow colouring of the steps | 2019/09/08-05:36
#292 | [danielhelfand] add SilenceUsage: true to root.go | 2019/09/08-22:11
#293 | [Carlos Santana] Update install instructions in readme to 0.3.1 | 2019/09/08-23:39
#279 | [16yuki0702] Add deletion scenario to e2e test | 2019/09/09-02:17
#279 | [16yuki0702] Fix to use -f flag | 2019/09/09-02:17
#300 | [Chmouel Boudjnah] Use a older version of thrift | 2019/09/09-08:48
#300 | [Chmouel Boudjnah] Don't run go mod vendor on every build | 2019/09/09-08:48
#301 | [Chmouel Boudjnah] E2E tests fixes | 2019/09/09-12:00
#303 | [danielhelfand] add taskrun describe command | 2019/09/10-02:15
#304 | [16yuki0702] Fix document typos | 2019/09/10-04:45
null | [Piyush Garg] Fix interactive prompt with --last | 2019/09/10-07:04
null | [16yuki0702] Add canceling feature to taskrun command | 2019/09/10-08:23
null | [Chmouel Boudjnah] Improve release script | 2019/09/11-10:35
null | [Sunil Thaha] Doc: Improve taskrun help example | 2019/09/12-02:09
null | [Piyush Garg] Fix -n not working with pipeline logs | 2019/09/12-02:23
null | [Piyush Garg] Show descriptive failure message | 2019/09/12-03:36
null | [danielhelfand] change error message returned by task for namespace | 2019/09/16-06:48
null | [Chmouel Boudjnah] Add a Tasrun to build rpm. | 2019/09/17-01:52
null | [Chmouel Boudjnah] Add information about copr rpm package repo in README | 2019/09/17-01:52
null | [Chmouel Boudjnah] Use khuram spec files which does a proper source build | 2019/09/17-01:52
null | [Chmouel Boudjnah] Update README with distros supported for dnf install | 2019/09/17-01:52
null | [Nikhil Thomas] Fix CI breakage | 2019/09/19-23:57
null | [Andrea Frittoli] Fix the logs command when creating a pipelinerun | 2019/09/20-01:57
null | [16yuki0702] Adding missing copyright header | 2019/09/23-04:47
null | [danielhelfand] correct copr package section typos | 2019/09/23-08:38
null | [danielhelfand] align pipeline describe output with other describe commands | 2019/09/24-04:58
null | [Chmouel Boudjnah] Add no colour option | 2019/09/24-05:24
null | [Chmouel Boudjnah] Disable nocolour test | 2019/09/24-05:24
null | [Chmouel Boudjnah] Generate documentation | 2019/09/24-05:24
null | [danielhelfand] align output with task describe command | 2019/09/24-05:36
null | [cappyzawa] fix misspell based on https://goreportcard.com/report/github.com/tektoncd/cli#misspell | 2019/09/24-06:20
null | [danielhelfand] add check to taskrun cancel for already executed taskrun | 2019/09/24-07:56
null | [Pradeep Kumar] Common method to get last run for a pipeline | 2019/09/24-08:17
null | [Pradeep Kumar] correts imports order | 2019/09/24-08:17
null | [Andrea Frittoli] Improve the error message on pipeline create | 2019/09/24-09:40
null | [Andrea Frittoli] Fix the logs command when creating a pipelinerun | 2019/09/24-09:40
null | [danielhelfand] add check to pipelinerun cancel for already executed pipelinerun | 2019/09/25-09:11
null | [Vincent Demeester] Bump tektoncd/pipeline to 0.7.x | 2019/09/25-10:02
null | [Vincent Demeester] bump github.com/AlecAivazis/survey/v2 to v2.0.4 | 2019/09/25-10:02
null | [Khurram Baig] Add Vendored Dependencies to RPM Spec | 2019/09/26-03:03

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@hrishin hrishin Awaiting requested review from hrishin

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot compile with go1.13
4 participants
@chmouel @googlebot @tekton-robot @vdemeester