Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align TaskRun Describe Output with Task Describe Output #324

Merged
merged 1 commit into from
Sep 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/cmd/taskrun/describe.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Message
{{ $msg }}
{{- end }}
Inputs
Input Resources
{{- $l := len .TaskRun.Spec.Inputs.Resources }}{{ if eq $l 0 }}
No resources
{{- else }}
Expand All @@ -56,7 +56,7 @@ NAME RESOURCE REF
{{- end }}
{{- end }}
Outputs
Output Resources
{{- $l := len .TaskRun.Spec.Outputs.Resources }}{{ if eq $l 0 }}
No resources
{{- else }}
Expand Down Expand Up @@ -84,7 +84,7 @@ Steps
{{- $l := len .TaskRun.Status.Steps }}{{ if eq $l 0 }}
No steps
{{- else }}
STEP NAME
NAME
{{- range $steps := .TaskRun.Status.Steps }}
{{ $steps.Name }}
{{- end }}
Expand Down
14 changes: 7 additions & 7 deletions pkg/cmd/taskrun/describe_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ Status
STARTED DURATION STATUS
--- --- Succeeded
Inputs
Input Resources
No resources
Outputs
Output Resources
No resources
Params
Expand Down Expand Up @@ -146,12 +146,12 @@ Status
STARTED DURATION STATUS
9 minutes ago --- Succeeded
Inputs
Input Resources
NAME RESOURCE REF
git git
image-input image
Outputs
Output Resources
NAME RESOURCE REF
image-output image
image-output2 image
Expand All @@ -162,7 +162,7 @@ input param
input2 param2
Steps
STEP NAME
NAME
step1
step2
`
Expand Down Expand Up @@ -213,10 +213,10 @@ STARTED DURATION STATUS
Message
Testing tr failed
Inputs
Input Resources
No resources
Outputs
Output Resources
No resources
Params
Expand Down