Allow passing labels to start #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
approved
|
The following is the coverage report on pkg/.
|
piyush-garg
reviewed
Oct 2, 2019
pkg/cmd/pipeline/start.go
Outdated
| return nil | ||
| } | ||
|
|
||
| pr.ObjectMeta.Labels = labels |
There was a problem hiding this comment.
Just a thought, this will remove the old labels. I think we should keep the old labels and add new ones. In the case of repeat, we keep the new one.
There was a problem hiding this comment.
you are right, and i was just being lazy! thanks mister senior principal to keep me straight! 😀 👨🏫
Add -l flag for start to pass labels to pipelineruns (and then to pods) Closes tektoncd#339 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel
force-pushed
the
issue-339-pass-labels
branch
from
724b01b
to
8802eaa
Compare
|
The following is the coverage report on pkg/.
|
vdemeester
approved these changes
Oct 2, 2019
| @@ -132,6 +134,7 @@ like cat,foo.bar | |||
| c.Flags().StringSliceVar(&opt.ServiceAccounts, "task-serviceaccount", []string{}, "pass the service account corresponding to the task") | |||
| flags.AddShellCompletion(c.Flags().Lookup("task-serviceaccount"), "__kubectl_get_serviceaccount") | |||
| c.Flags().BoolVarP(&opt.Last, "last", "L", false, "re-run the pipeline using last pipelinerun values") | |||
There was a problem hiding this comment.
Didn't we want to remove the shorthand flag for --last ?
There was a problem hiding this comment.
yeah we moved it to -L #340 and unified labels to -l as kubectl and other kube tools,
tekton-robot
added
the
do-not-merge/hold
piyush-garg
approved these changes
Oct 3, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
chmouel
added a commit
that referenced
this pull request
Nov 8, 2019
#336 | [Chmouel Boudjnah] Update templating to use `$(…)` instead of `${…}` | 2019/09/26-04:37 #338 | [Chmouel Boudjnah] Update README to 0.4.0 | 2019/09/26-06:33 #338 | [Chmouel Boudjnah] Add Centos8 | 2019/09/26-06:33 #337 | [Chmouel Boudjnah] Fix spec file path | 2019/09/26-06:49 #323 | [Piyush Garg] Add task describe subcommand | 2019/09/30-07:10 #340 | [Chmouel Boudjnah] Cleanup -l flag across commands | 2019/09/30-10:50 #319 | [16yuki0702] Add condition list command | 2019/10/01-02:58 #343 | [Chmouel Boudjnah] Add information about docs and checks for github pr template | 2019/10/02-06:50 #344 | [Chmouel Boudjnah] Add documentation check | 2019/10/02-18:27 #342 | [Chmouel Boudjnah] Allow passing labels to start | 2019/10/03-02:44 null | [Chmouel Boudjnah] Update the new brew location | 2019/10/03-04:16 null | [danielhelfand] check if namespace exists for task list command | 2019/10/08-10:06 null | [Piyush Garg] Set namespace in e2e tests | 2019/10/09-03:16 null | [Pradeep Kumar] Adds command to create new resource interactively | 2019/10/09-06:00 null | [Pradeep Kumar] adds doc for resource create command | 2019/10/09-06:00 null | [Pradeep Kumar] review comments addressed | 2019/10/09-06:00 null | [Pradeep Kumar] removes os.Exit(1) for interrupts | 2019/10/09-06:00 null | [Pradeep Kumar] rebase and auto generate docs | 2019/10/09-06:00 null | [Vincent Demeester] Bump tektoncd/plumbing dependency ⛽️ | 2019/10/09-20:46 null | [danielhelfand] add namespace check to task delete command | 2019/10/09-21:07 null | [Piyush Garg] Refactoring resource list | 2019/10/10-07:50 null | [Piyush Garg] Fix unit tests | 2019/10/10-10:48 null | [Chmouel Boudjnah] Show logs right after starting the pipeline | 2019/10/10-11:08 null | [danielhelfand] add namespace check to task describe command | 2019/10/13-10:40 null | [Pradeep Kumar] Fixes test increase timeout for expect | 2019/10/15-02:13 null | [danielhelfand] add namespace check to taskrun desc command | 2019/10/16-03:28 null | [Chmouel Boudjnah] Don't show just Error if container came back only with "Error" | 2019/10/16-03:47 null | [danielhelfand] add namespace check to taskrun list command | 2019/10/16-03:47 null | [danielhelfand] add tkn condition to README | 2019/10/16-04:54 null | [Pradeep Kumar] Use *** instead of plain text for password | 2019/10/17-08:16 null | [Pradeep Kumar] Change way of question for insecure parameter | 2019/10/18-03:07 null | [danielhelfand] refactor NamespaceExists | 2019/10/18-09:47 null | [Piyush Garg] Add feature to start task | 2019/10/18-12:04 null | [Pradeep Kumar] removes complexity of read timeout from test | 2019/10/21-06:03 null | [Pradeep Kumar] remove test for interrupt change pull url | 2019/10/21-06:03 null | [Chmouel Boudjnah] Syncronize cobra fork with latest | 2019/10/21-23:17 null | [Chmouel Boudjnah] Update the whole go mod dependencies shbang | 2019/10/21-23:17 null | [danielhelfand] add namespace check to taskrun delete command | 2019/10/22-02:04 null | [danielhelfand] add namespace check to taskrun logs command | 2019/10/22-02:25 null | [danielhelfand] add namespace check to taskrun cancel command | 2019/10/22-02:36 null | [Piyush Garg] Fix panic on pipeline logs | 2019/10/22-09:26 null | [hriships] Change for release and tagging | 2019/10/23-04:02 null | [danielhelfand] add namespace check to pipeline list command | 2019/10/23-07:42 null | [danielhelfand] add namespace check to condition list command | 2019/10/24-01:38 null | [danielhelfand] add namespace check to pipeline logs command | 2019/10/24-01:50 null | [danielhelfand] add namespace check to clustertask commands | 2019/10/24-01:50 null | [danielhelfand] add namespace check to pipeline delete command | 2019/10/24-02:03 null | [danielhelfand] add namespace check to pipeline describe command | 2019/10/24-02:03 null | [16yuki0702] Add delete condition command | 2019/10/24-02:15 null | [16yuki0702] Extract checking option | 2019/10/24-02:15 null | [Chmouel Boudjnah] Bump tektoncd/pipeline to 0.8.0 | 2019/10/24-09:14 null | [Chmouel Boudjnah] Bump some dependency related to opencensus.io to fix go mod tidy | 2019/10/24-23:42 null | [Chmouel Boudjnah] Fix staticcheck error on version/version.go | 2019/10/24-23:42 null | [danielhelfand] add namespace check to resource list command | 2019/10/24-23:55 null | [Andrea Frittoli] Use targetURI for cloudEvent resource details | 2019/10/25-02:04 null | [danielhelfand] add namespace check to resource create command | 2019/10/25-02:26 null | [danielhelfand] add namespace check to condition delete command | 2019/10/25-02:26 null | [Vincent Demeester] Bump plumbing to latest version | 2019/10/25-03:23 null | [Chmouel Boudjnah] Add banners when building docs | 2019/10/25-03:50 null | [Chmouel Boudjnah] Increase GolangCI timeout | 2019/10/25-03:50 null | [Chmouel Boudjnah] Generate windows binary release files as zip file | 2019/10/25-04:30 null | [danielhelfand] add namespace check to resource delete command | 2019/10/25-04:47 null | [Chmouel Boudjnah] Remove 386 and arm archs | 2019/10/25-08:33 null | [danielhelfand] add namespace check to pr describe command | 2019/10/25-12:44 null | [danielhelfand] add namespace check to resource describe command | 2019/10/25-21:32 null | [danielhelfand] add namespace check to pr delete command | 2019/10/27-09:36 null | [danielhelfand] add namespace check to pr logs command | 2019/10/27-10:07 null | [danielhelfand] add namespace check to pr cancel command | 2019/10/27-12:48 null | [danielhelfand] add namespace check to pr list command | 2019/10/28-03:27 null | [danielhelfand] add namespace check to task start command | 2019/10/28-08:54 null | [danielhelfand] add namespace check to pipeline start command | 2019/10/28-09:51 null | [danielhelfand] clean up pipeline start test and correct task start namespace check | 2019/10/28-10:34 null | [Chmouel Boudjnah] Allow specify a specific release.yaml when setting up pipelines | 2019/10/29-10:48 null | [16yuki0702] Modify delete command to using delete options | 2019/10/29-21:01 null | [16yuki0702] Remove unnecessary struct | 2019/10/29-21:01 null | [Chmouel Boudjnah] Add installation instructions for Win to README kind/feature | 2019/10/30-05:03 null | [Piyush Garg] Fix make lint warning | 2019/10/30-09:12 null | [Chmouel Boudjnah] Make sure we are in the right directory when launching the tests | 2019/10/30-10:15 null | [Piyush Garg] Enable golint | 2019/10/31-04:22 null | [danielhelfand] check if taskref and pipelineref exist for describe commands | 2019/10/31-10:39 null | [Piyush Garg] Remove date from man pages | 2019/11/04-04:15 null | [Piyush Garg] Show logs after task start | 2019/11/04-21:49 null | [Piyush Garg] Fix taskrun log throwing error | 2019/11/04-21:49 null | [danielhelfand] remove space from resource and param errors | 2019/11/05-04:30 null | [Eric Carboni] Update README.md | 2019/11/05-04:30 null | [16yuki0702] Add options test cases | 2019/11/05-04:49 null | [Daniel Helfand] adding path information to Windows install instructions | 2019/11/06-02:46 null | [Pradeep Kumar] starts pipeline with new resource | 2019/11/06-05:09 null | [Piyush Garg] Show params in pipeline describe command | 2019/11/07-09:58 null | [Vincent Demeester] Add danielhelfand as OWNER 🐱 | 2019/11/07-10:19 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add -l flag for start to pass labels to pipelineruns (and then to pods)
Closes #339
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes