-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starts pipeline with new resource #371
Conversation
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
/retest |
The following is the coverage report on pkg/.
|
/test pull-tekton-cli-build-cross-tests |
/test pull-tekton-cli-build-tests |
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
/test pull-tekton-cli-build-cross-tests |
The following is the coverage report on pkg/.
|
/test pull-tekton-cli-unit-tests |
1 similar comment
/test pull-tekton-cli-unit-tests |
pkg/cmd/pipeline/start.go
Outdated
opt.Resources = append(opt.Resources, res.Name+"="+newres.Name) | ||
return nil | ||
} | ||
// first ask if user wants to create new resource or use existing one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do that (ask the question first), or should we had an "create a resource" option in the list ? (the later seems tricker to achieve though 😓)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vdemeester
@sthaha also suggests the same thing.
It was not that tricky as we thought of, I have updated the PR addressing the same.
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
/test pull-tekton-cli-build-tests |
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
@pradeepitm12 build job is failing. Shall we fix that? |
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
The following is the coverage report on pkg/.
|
start pipeline shows the list of resources available in the namespace, also adds an option in the last to create new resource on the go start pipeline directly jumps to create resource flow if there are no resource found in the namespace Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
The following is the coverage report on pkg/.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-cli-unit-tests |
1 similar comment
/test pull-tekton-cli-unit-tests |
this provides user with comfort to start pipeline with two
options
Signed-off-by: Pradeep Kumar pradkuma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docs
andmake man
if needed.make check
See the contribution guide
for more details.
Release Notes