Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 386 and arm archs #406

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Remove 386 and arm archs #406

merged 1 commit into from
Oct 25, 2019

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Oct 25, 2019 •
edited
Loading

Feel free to convince otherwise that it may be used =)

It decrease CI times too and make it less confusing for users to know which one to choose,

Remove 386 and arm architectures from the binary release

@chmouel
Remove 386 and arm archs
3b8b571 
Feel free to convince otherwise that it may be used =)

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2019
vdemeester
vdemeester approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@tekton-robot tekton-robot merged commit a388508 into tektoncd:master Oct 25, 2019
@chmouel chmouel deleted the remove-usless-arch branch October 25, 2019 13:39
@chmouel chmouel modified the milestones: 0.6.0, 0.5.0 🐱 Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@hrishin hrishin Awaiting requested review from hrishin

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
0.5.0 🐱
Development

Successfully merging this pull request may close these issues.
4 participants
@chmouel @tekton-robot @vdemeester @googlebot